Page MenuHomePhabricator
Differential D14023

[lib] Don't created thin thread if call to identity server failed when adding friends
ClosedPublic
Actions

Authored by angelika on Nov 22 2024, 1:23 PM.
Tags
None
Referenced Files
F3521836: D14023.id46378.diff
Mon, Dec 23, 4:59 AM
Unknown Object (File)
Fri, Dec 13, 11:17 PM
Unknown Object (File)
Fri, Dec 13, 11:16 PM
Unknown Object (File)
Mon, Dec 9, 7:00 AM
Unknown Object (File)
Tue, Dec 3, 3:19 AM
Unknown Object (File)
Mon, Dec 2, 3:07 AM
Unknown Object (File)
Sat, Nov 30, 2:39 AM
Unknown Object (File)
Sat, Nov 30, 1:45 AM
View All 19 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
ashoat
Commits
rCOMMcb47dbdcae97: [lib] Don't created thin thread if call to identity server failed when adding…
Summary

https://linear.app/comm/issue/ENG-9509/accepting-a-friend-request-on-web-creates-thin-thread

Related discussion: https://phab.comm.dev/D13940#389316
Now we're throwing an error just in useUpdateRelationships(), there are no changes in getUserIdentities()
and useUsersSupportThickThreads() returns Map instead of Set

Depends on D14022

Test Plan

Throw some error in fetchUserIdentitiesPromise() so that finding user indentity always fails
Mobile user goes to profile -> Friend list and adds the web user as a friend
Before a thin thread was created. Now mobile user sees an alert, because there is no auxUserInfo, no thick thread and call to identity server fails.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Nov 22 2024, 1:23 PM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 22 2024, 1:23 PM
angelika mentioned this in D13940: [lib] Don't swallow errors in getUserIdentities() call.Nov 22 2024, 1:25 PM
Harbormaster completed remote builds in B32788: Diff 45975.Nov 22 2024, 1:40 PM
angelika requested review of this revision.Nov 22 2024, 1:40 PM
ashoat accepted this revision.Mon, Nov 25, 8:18 AM
ashoat added inline comments.
lib/hooks/user-identities-hooks.js
10 ↗(On Diff #45975)

It looks like null is not possible... might be good to be more specific

This revision is now accepted and ready to land.Mon, Nov 25, 8:18 AM
angelika updated this revision to Diff 46375.Thu, Dec 12, 4:43 AM

Rebase and change type from ?boolean to boolean | void

Harbormaster completed remote builds in B33057: Diff 46375.Thu, Dec 12, 5:08 AM
angelika marked an inline comment as done.Thu, Dec 12, 5:13 AM
Closed by commit rCOMMcb47dbdcae97: [lib] Don't created thin thread if call to identity server failed when adding… (authored by angelika). · Explain WhyThu, Dec 12, 5:23 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMcb47dbdcae97: [lib] Don't created thin thread if call to identity server failed when adding….

Revision Contents
Changeset List

Diff 46378

View Options

lib/hooks/relationship-hooks.js

Loading...
View Options

lib/hooks/thread-search-hooks.js

Loading...
View Options

lib/hooks/user-identities-hooks.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

web/chat/chat-thread-composer.react.js

Loading...
View Options

web/utils/thread-utils.js

Loading...