[identity] Store backup UserKeys in DDB transaction
ClosedPublic
Actions

Authored by bartek on Jan 30 2025, 9:49 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMc7f39d648ebf: [identity] Store backup UserKeys in DDB transaction

Summary

If UserKeys backup was specified during primary device registration (during backup restore protocol), we want to store it in DDB along with device list update transactionally.

Depends on D14278

Test Plan

Device list integration tests.
Specifying Some(backup_item) as function argument causes saving it in the backup-service-backups table

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jan 30 2025, 9:49 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 30 2025, 9:49 AM

bartek added a child revision: D14280: [proto] Add UserKeys backup fields to RestoreUserRequest.Jan 30 2025, 9:49 AM

Harbormaster failed remote builds in B33357: Diff 46854!Jan 30 2025, 10:06 AM

Rebase

bartek published this revision for review.Jan 30 2025, 11:40 AM

bartek edited the summary of this revision. (Show Details)

bartek edited the test plan for this revision. (Show Details)

bartek mentioned this in D14283: [identity] Upload UserKeys backup in RestoreUser RPC.Jan 30 2025, 11:51 AM

Harbormaster completed remote builds in B33366: Diff 46864.Jan 30 2025, 11:54 AM

As discussed offline, we need to mention this in the task for backup cleanup - right now User Keys upload from Identity works differently than Backup in terms of cleanup

services/identity/src/database/device_list.rs
1328	Can we create a task to make it mandatory? Currently, we have this RPC released only for staff users, so there is a high chance we can release it to the public when all clients are capable of uploading User Keys when restoring, which should be required, but we allow it to be optional only because of backward compatibility for staff users.

This revision is now accepted and ready to land.Jan 30 2025, 1:04 PM

bartek added inline comments.Jan 31 2025, 2:04 PM

services/identity/src/database/device_list.rs
1328	As you can see, this function is also called in RegisterUser RPCs where we don't upload UserKeys but rather let BackupHandler do it after RPC finishes. Unless we want to update registration RPCs as well, this has to stay optional.