[lib] avoid processing `DEVICE_LIST_UPDATE_SUCCESS` for logged-in users
ClosedPublic
Actions

Authored by kamil on Feb 13 2025, 2:55 PM.

Details

Reviewers

tomek
bartek
angelika

Commits

rCOMM8bc621612f82: [lib] avoid processing `DEVICE_LIST_UPDATE_SUCCESS` for logged-in users

Summary

Context in ENG-10187.

This is one more improvement, we should ignore the logic SecondaryDeviceQRAuthContextProvider when the device is logged in. The fix in the previous diff the stack should be enough, but I feel like adding this makes it more reliable.

Depends on D14359

Test Plan

Issue from the task no longer occurs. Keyserver notifs are working

Diff Detail

Repository

rCOMM Comm

Branch

follow-ups

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Feb 13 2025, 2:55 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 13 2025, 2:55 PM

kamil edited the summary of this revision. (Show Details)Feb 13 2025, 2:58 PM

kamil published this revision for review.Feb 13 2025, 3:15 PM

Harbormaster completed remote builds in B33511: Diff 47095.Feb 13 2025, 3:19 PM

tomek accepted this revision.Feb 13 2025, 4:57 PM

This revision is now accepted and ready to land.Feb 13 2025, 4:57 PM

Closed by commit rCOMM8bc621612f82: [lib] avoid processing `DEVICE_LIST_UPDATE_SUCCESS` for logged-in users. · Explain WhyFeb 14 2025, 9:35 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM8bc621612f82: [lib] avoid processing `DEVICE_LIST_UPDATE_SUCCESS` for logged-in users.

Revision Contents
Changeset List

Path

Size

lib/

components/

secondary-device-qr-auth-context-provider.react.js

7 lines

Diff 47095

View Options

lib/components/secondary-device-qr-auth-context-provider.react.js

[lib] avoid processing `DEVICE_LIST_UPDATE_SUCCESS` for logged-in usersClosedPublicActions