Paths

Table of Contentst

[native] improve logging in `PrimaryDeviceQRAuthContextProvider`
ClosedPublic
Actions

Authored by kamil on Feb 17 2025, 3:26 PM.

Details

Reviewers

tomek
bartek
angelika

Commits

rCOMMb794a38fa60a: [native] improve logging in `PrimaryDeviceQRAuthContextProvider`

Summary

Context in ENG-10186.

Test Plan

Mock identity error and see the video:

Diff Detail

Repository

rCOMM Comm

Branch

improve-logs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Feb 17 2025, 3:26 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 17 2025, 3:26 PM

kamil published this revision for review.Feb 17 2025, 3:26 PM

Harbormaster failed remote builds in B33528: Diff 47127!Feb 17 2025, 3:40 PM

Harbormaster failed remote builds in B33529: Diff 47128!Feb 17 2025, 3:48 PM

tomek accepted this revision.Feb 17 2025, 4:52 PM

tomek added inline comments.

native/account/qr-auth/primary-device-qr-auth-context-provider.js
189–190 ↗	(On Diff #47128)	We can consider calling `console.log` inside `addLog` function

This revision is now accepted and ready to land.Feb 17 2025, 4:52 PM

kamil added inline comments.Feb 17 2025, 5:40 PM

native/account/qr-auth/primary-device-qr-auth-context-provider.js
189–190 ↗	(On Diff #47128)	good call, I’ll do it as a follow-up

This revision was landed with ongoing or failed builds.Feb 17 2025, 5:41 PM

Closed by commit rCOMMb794a38fa60a: [native] improve logging in `PrimaryDeviceQRAuthContextProvider`. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb794a38fa60a: [native] improve logging in `PrimaryDeviceQRAuthContextProvider`.

Harbormaster completed remote builds in B33529: Diff 47128.Feb 17 2025, 5:47 PM

kamil mentioned this in D14377: [lib] add `console.log` in `DebugLogsContextProvider`.Feb 17 2025, 5:58 PM

kamil added inline comments.Feb 17 2025, 5:59 PM

native/account/qr-auth/primary-device-qr-auth-context-provider.js
189–190 ↗	(On Diff #47128)	D14377

kamil mentioned this in rCOMMe2c1b9f70308: [lib] add `console.log` in `DebugLogsContextProvider`.Feb 18 2025, 11:36 AM

Revision Contents
Changeset List

Path

Size

native/

account/

qr-auth/

primary-device-qr-auth-context-provider.js

22 lines

Diff 47127

View Options

native/account/qr-auth/primary-device-qr-auth-context-provider.js

[native] improve logging in `PrimaryDeviceQRAuthContextProvider`ClosedPublicActions