Page MenuHomePhabricator
Differential D14393

[native] Wait with registration and restoration for the logout to conclude
ClosedPublic
Actions

Authored by tomek on Feb 20 2025, 6:43 AM.
Tags
None
Referenced Files
F5581621: D14393.diff
Sat, Apr 12, 7:54 PM
Unknown Object (File)
Wed, Apr 2, 2:25 PM
Unknown Object (File)
Tue, Apr 1, 7:52 PM
Unknown Object (File)
Sat, Mar 29, 5:47 AM
Unknown Object (File)
Tue, Mar 25, 5:30 PM
Unknown Object (File)
Tue, Mar 25, 7:23 AM
Unknown Object (File)
Tue, Mar 25, 6:41 AM
Unknown Object (File)
Mon, Mar 24, 4:43 PM
View All 29 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
Commits
rCOMM95b84087e325: [native] Wait with registration and restoration for the logout to conclude
Summary

Show the loading state before the logout is concluded.

https://linear.app/comm/issue/ENG-10224/block-the-restoration-until-the-logout-is-concluded

Test Plan

Log out and check if the loading state is displayed. Also check that without the internet connection.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
account/
13 lines

Diff 47171

View Options

native/account/logged-out-modal.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { logOut, logOutActionTypes } from 'lib/actions/user-actions.js'; import { logOut, logOutActionTypes } from 'lib/actions/user-actions.js';
import { preRequestUserStateSelector } from 'lib/selectors/account-selectors.js'; import { preRequestUserStateSelector } from 'lib/selectors/account-selectors.js';
import { import {
cookieSelector, cookieSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector, lastCommunicatedPlatformDetailsSelector,
} from 'lib/selectors/keyserver-selectors.js'; } from 'lib/selectors/keyserver-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { accountHasPassword } from 'lib/shared/account-utils.js'; import { accountHasPassword } from 'lib/shared/account-utils.js';
import { useInitialNotificationsEncryptedMessage } from 'lib/shared/crypto-utils.js';
import Socket, { type BaseSocketProps } from 'lib/socket/socket.react.js'; import Socket, { type BaseSocketProps } from 'lib/socket/socket.react.js';
import { logInActionSources } from 'lib/types/account-types.js'; import { logInActionSources } from 'lib/types/account-types.js';
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
fetchNewCookieFromNativeCredentials, fetchNewCookieFromNativeCredentials,
} from 'lib/utils/action-utils.js'; } from 'lib/utils/action-utils.js';
import { InputStateContext } from './input/input-state.js'; import { InputStateContext } from './input/input-state.js';
import { import {
activeMessageListSelector, activeMessageListSelector,
nativeCalendarQuery, nativeCalendarQuery,
} from './navigation/nav-selectors.js'; } from './navigation/nav-selectors.js';
import { NavContext } from './navigation/navigation-context.js'; import { NavContext } from './navigation/navigation-context.js';
import { useSelector } from './redux/redux-utils.js'; import { useSelector } from './redux/redux-utils.js';
import { noDataAfterPolicyAcknowledgmentSelector } from './selectors/account-selectors.js'; import { noDataAfterPolicyAcknowledgmentSelector } from './selectors/account-selectors.js';
import { import {
openSocketSelector, openSocketSelector,
sessionIdentificationSelector, sessionIdentificationSelector,
nativeGetClientResponsesSelector, nativeGetClientResponsesSelector,
nativeSessionStateFuncSelector, nativeSessionStateFuncSelector,
} from './selectors/socket-selectors.js'; } from './selectors/socket-selectors.js';
import Alert from './utils/alert.js'; import Alert from './utils/alert.js';
import { useInitialNotificationsEncryptedMessage } from './utils/crypto-utils.js'; import { nativeNotificationsSessionCreator } from './utils/crypto-utils.js';
import { decompressMessage } from './utils/decompress.js'; import { decompressMessage } from './utils/decompress.js';
const NativeSocket: React.ComponentType<BaseSocketProps> = const NativeSocket: React.ComponentType<BaseSocketProps> =
React.memo<BaseSocketProps>(function NativeSocket(props: BaseSocketProps) { React.memo<BaseSocketProps>(function NativeSocket(props: BaseSocketProps) {
const inputState = React.useContext(InputStateContext); const inputState = React.useContext(InputStateContext);
const navContext = React.useContext(NavContext); const navContext = React.useContext(NavContext);
const cookie = useSelector(cookieSelector); const cookie = useSelector(cookieSelector);
Show All 11 Lines React.memo<BaseSocketProps>(function NativeSocket(props: BaseSocketProps) {
const currentUserInfo = useSelector(state => state.currentUserInfo); const currentUserInfo = useSelector(state => state.currentUserInfo);
const openSocket = useSelector(openSocketSelector); const openSocket = useSelector(openSocketSelector);
invariant(openSocket, 'openSocket failed to be created'); invariant(openSocket, 'openSocket failed to be created');
const sessionIdentification = useSelector(sessionIdentificationSelector); const sessionIdentification = useSelector(sessionIdentificationSelector);
const preRequestUserState = useSelector(preRequestUserStateSelector); const preRequestUserState = useSelector(preRequestUserStateSelector);
const getInitialNotificationsEncryptedMessage = const getInitialNotificationsEncryptedMessage =
useInitialNotificationsEncryptedMessage(); useInitialNotificationsEncryptedMessage(
nativeNotificationsSessionCreator,
);
const getClientResponses = useSelector(state => const getClientResponses = useSelector(state =>
nativeGetClientResponsesSelector({ nativeGetClientResponsesSelector({
redux: state, redux: state,
navContext, navContext,
getInitialNotificationsEncryptedMessage, getInitialNotificationsEncryptedMessage,
}), }),
); );
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines