Page MenuHomePhabricator
Differential D14303

[native] Migrate pinch gesture handling in FullScreenViewModal
ClosedPublic
Actions

Authored by angelika on Feb 6 2025, 5:09 PM.
Tags
None
Referenced Files
F6240565: D14303.diff
Thu, Apr 24, 11:02 PM
Unknown Object (File)
Tue, Apr 15, 2:03 PM
Unknown Object (File)
Tue, Apr 15, 2:01 PM
Unknown Object (File)
Tue, Apr 15, 12:56 AM
Unknown Object (File)
Mon, Apr 14, 11:53 PM
Unknown Object (File)
Mon, Apr 14, 11:22 PM
Unknown Object (File)
Mon, Apr 14, 10:27 PM
Unknown Object (File)
Mon, Apr 14, 2:08 PM
View All 48 Files
Subscribers
ashoat

Details

Reviewers
tomek
ashoat
Commits
rCOMMc84b9db1aeb4: [native] Migrate pinch gesture handling in FullScreenViewModal
Summary

https://linear.app/comm/issue/ENG-8150/convert-fullscreenviewmodal-to-reanimated-2-syntax

Migrate`pinchUpdate` method which updates image scale when pinch gesture is in progress based on the delta between current and last pinch scale, just like in the original implementation.

Depends on D14302

Test Plan

Tested after migration: verify pinch gesture works.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Feb 6 2025, 5:09 PM
angelika held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 6 2025, 5:09 PM
angelika added a child revision: D14304: [native] Migrate single tap gesture handling in FullScreenViewModal.Feb 6 2025, 5:11 PM
Harbormaster completed remote builds in B33418: Diff 46947.Feb 6 2025, 5:55 PM
angelika edited the summary of this revision. (Show Details)Feb 7 2025, 5:27 AM
angelika added inline comments.
native/components/full-screen-view-modal.react.js
89–101 ↗(On Diff #46947)

The math for delta calculations are taken from here

angelika updated this revision to Diff 47081.Feb 12 2025, 8:51 PM
angelika marked an inline comment as not done.

Rebase & bugfixes

angelika published this revision for review.Feb 12 2025, 9:06 PM
Harbormaster completed remote builds in B33497: Diff 47081.Feb 12 2025, 9:50 PM
ashoat accepted this revision.Feb 14 2025, 12:51 AM
ashoat added inline comments.
native/components/full-screen-view-modal.react.js
1191–1192 ↗(On Diff #47081)

Looks like updating these is handled in D14311

This revision is now accepted and ready to land.Feb 14 2025, 12:51 AM
angelika updated this revision to Diff 47185.Feb 20 2025, 2:13 PM

Rebase & bugfixes

angelika updated this revision to Diff 47219.Feb 24 2025, 3:51 AM

Rebase

Harbormaster completed remote builds in B33599: Diff 47219.Feb 24 2025, 5:18 AM
Closed by commit rCOMMc84b9db1aeb4: [native] Migrate pinch gesture handling in FullScreenViewModal (authored by angelika). · Explain WhyFeb 25 2025, 2:48 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMc84b9db1aeb4: [native] Migrate pinch gesture handling in FullScreenViewModal.

Revision Contents
Changeset List

PathSize
native/
components/
75 lines

Diff 47185

View Options

native/components/full-screen-view-modal.react.js

Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Lines const messageDatas = userIDs.map(otherUserID => ({
creatorID: viewer.userID, creatorID: viewer.userID,
creatorFID: viewerFID, creatorFID: viewerFID,
targetID: otherUserID, targetID: otherUserID,
targetFID: request.userIDsToFID[otherUserID], targetFID: request.userIDsToFID[otherUserID],
time: now, time: now,
operation: 'farcaster_mutual', operation: 'farcaster_mutual',
})); }));
await createMessages(viewer, messageDatas, 'broadcast'); await createMessages(viewer, messageDatas, 'broadcast');
} else if (request.action === relationshipActions.ACKNOWLEDGE) {
updateIDs.push(...userIDs);
const insertRows = userIDs.map(userID => {
const [user1, user2] = sortUserIDs(viewer.userID, userID);
return { user1, user2, status: undirectedStatus.KNOW_OF };
});
const updateDatas = await updateChangedUndirectedRelationships(insertRows);
inkaAuthorUnsubmitted
Done
Inline Actions

updateChangedUndirectedRelationships only updates the relationship if there was none, or the relationship status provided it greater than the one in the db. This will not be the case here, because KNOW_OF is 0-the lowest possible value. So we will not override a more meaningful relationship.

inka: `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the…
tomekUnsubmitted
Not Done
Inline Actions

Makes sense, but is there an easy way of checking if the relationship doesn't need to be updated?

tomek: Makes sense, but is there an easy way of checking if the relationship doesn't need to be…
inkaAuthorUnsubmitted
Done
Inline Actions

The only thing this function does is checking if the relationship needs to be updated, and if so updates it. So I don't think it makes sense to duplicate this logic.
We discussed this offline and agreed that this code makes sense and can be left as is.

inka: The only thing this function does is checking if the relationship needs to be updated, and if…
await createUpdates(updateDatas);
} else { } else {
invariant( invariant(
false, false,
`action ${request.action} is invalid or not supported currently`, `action ${request.action} is invalid or not supported currently`,
); );
} }
await createUpdates( await createUpdates(
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines