Page MenuHomePhabricator
Differential D14411

[native] Remove tipHorizontalOffset from NUXTipsOverlay
ClosedPublic
Actions

Authored by angelika on Feb 25 2025, 3:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 4:10 PM
Unknown Object (File)
Sat, Apr 5, 10:03 AM
Unknown Object (File)
Fri, Apr 4, 9:21 PM
Unknown Object (File)
Fri, Apr 4, 2:17 PM
Unknown Object (File)
Fri, Mar 21, 10:14 AM
Unknown Object (File)
Tue, Mar 18, 11:49 PM
Unknown Object (File)
Fri, Mar 14, 12:12 PM
Unknown Object (File)
Mar 9 2025, 4:37 AM
View All 26 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMe2e38d447227: [native] Remove tipHorizontalOffset from NUXTipsOverlay
Summary

tipHorizontalOffsetRef has a reanimated v1 value, but from reading the code I can deduce that this value is set and
not read anywhere. Therefore it can be removed.

Also onTipContainerLayout just sets tipHorizontalOffsetRef so it can also be removed.

Depends on D14410

Test Plan

flow, eslint, login to a new account and see that the tips at the beginning are working

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Feb 25 2025, 3:14 AM
angelika held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 25 2025, 3:14 AM
angelika edited the summary of this revision. (Show Details)Feb 25 2025, 3:14 AM
angelika added a parent revision: D14410: [native] Rename clampV2 to clamp.
angelika edited the summary of this revision. (Show Details)
angelika edited the summary of this revision. (Show Details)
angelika published this revision for review.Feb 25 2025, 3:36 AM
tomek accepted this revision.Feb 25 2025, 3:43 AM

Do we know what was the intention of this code and whether we have a corresponding logic in the Reanimated 2 code?

This revision is now accepted and ready to land.Feb 25 2025, 3:43 AM
angelika added a comment.Feb 25 2025, 5:17 AM
In D14411#400375, @tomek wrote:

Do we know what was the intention of this code and whether we have a corresponding logic in the Reanimated 2 code?

I guess this is just a leftover from migrating NUX tooltips from reanimated v1 to reanimated v2.

ashoat added a comment.Feb 25 2025, 9:06 AM

Was the NUX tooltips ever implemented in Reanimated v1? It's relatively new in our codebase

angelika added a comment.Feb 26 2025, 3:09 AM
In D14411#400429, @ashoat wrote:

Was the NUX tooltips ever implemented in Reanimated v1? It's relatively new in our codebase

It looks to me it was: https://phab.comm.dev/D13071

This revision was landed with ongoing or failed builds.Mar 3 2025, 5:58 AM
Closed by commit rCOMMe2e38d447227: [native] Remove tipHorizontalOffset from NUXTipsOverlay (authored by angelika). · Explain Why
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMe2e38d447227: [native] Remove tipHorizontalOffset from NUXTipsOverlay.

Revision Contents
Changeset List

PathSize
native/
tooltip/
29 lines

Diff 47265

View Options

native/tooltip/nux-tips-overlay.react.js

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
import { messageTypes } from '../message-types-enum.js'; import { messageTypes } from '../message-types-enum.js';
import type { RelativeUserInfo } from '../user-types.js'; import type { RelativeUserInfo } from '../user-types.js';
export type UpdateRelationshipMessageData = { export type TraditionalRelationshipOperation =
| 'request_sent'
| 'request_accepted';
export type FarcasterRelationshipOperation = 'farcaster_mutual';
export type UpdateTraditionalRelationshipMessageData = {
+type: 22, +type: 22,
+threadID: string, +threadID: string,
+creatorID: string, +creatorID: string,
+targetID: string, +targetID: string,
+time: number, +time: number,
+operation: 'request_sent' | 'request_accepted' | 'farcaster_mutual', +operation: TraditionalRelationshipOperation,
}; };
export type UpdateFarcasterRelationshipMessageData = {
+type: 22,
+threadID: string,
+creatorID: string,
+creatorFID: string,
+targetID: string,
+targetFID: string,
+time: number,
+operation: FarcasterRelationshipOperation,
};
export type UpdateRelationshipMessageData =
| UpdateTraditionalRelationshipMessageData
| UpdateFarcasterRelationshipMessageData;
export type RawUpdateRelationshipMessageInfo = { export type RawUpdateRelationshipMessageInfo = {
...UpdateRelationshipMessageData, ...UpdateRelationshipMessageData,
id: string, id: string,
}; };
export const rawUpdateRelationshipMessageInfoValidator: TInterface<RawUpdateRelationshipMessageInfo> = export const rawUpdateRelationshipMessageInfoValidator: TInterface<RawUpdateRelationshipMessageInfo> =
tShape<RawUpdateRelationshipMessageInfo>({ tShape<RawUpdateRelationshipMessageInfo>({
type: tNumber(messageTypes.UPDATE_RELATIONSHIP), type: tNumber(messageTypes.UPDATE_RELATIONSHIP),
Show All 21 Lines