Page MenuHomePhabricator
Differential D14432

[native] Move ErrorBoundary inside Identity and Tunnelbroker context
ClosedPublic
Actions

Authored by bartek on Mar 6 2025, 1:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 11:08 PM
Unknown Object (File)
Fri, Apr 4, 1:23 PM
Unknown Object (File)
Thu, Apr 3, 8:27 PM
Unknown Object (File)
Wed, Apr 2, 4:28 PM
Unknown Object (File)
Sun, Mar 30, 8:42 PM
Unknown Object (File)
Sun, Mar 30, 1:16 PM
Unknown Object (File)
Fri, Mar 28, 1:09 AM
Unknown Object (File)
Sun, Mar 23, 7:36 PM
View All 22 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
ashoat
Commits
rCOMMc019d4dbe1e7: [native] Move ErrorBoundary inside Identity and Tunnelbroker context
Summary

Implements solution 1 from ENG-10295.

Test Plan

Triggered crash from dev menu. The crash screen rendered successfully.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Mar 6 2025, 1:19 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMar 6 2025, 1:19 AM
Harbormaster failed remote builds in B33689: Diff 47366!Mar 6 2025, 1:33 AM
bartek published this revision for review.Mar 6 2025, 2:06 AM
ashoat accepted this revision.Mar 6 2025, 8:11 AM
This revision is now accepted and ready to land.Mar 6 2025, 8:11 AM
This revision was landed with ongoing or failed builds.Fri, Mar 14, 1:58 AM
Closed by commit rCOMMc019d4dbe1e7: [native] Move ErrorBoundary inside Identity and Tunnelbroker context (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMc019d4dbe1e7: [native] Move ErrorBoundary inside Identity and Tunnelbroker context.

Revision Contents
Changeset List

PathSize
native/
154 lines

Diff 47366

View Options

native/root.react.js

// @flow // @flow
import { useNavigation, useRoute } from '@react-navigation/native'; import { useNavigation, useRoute } from '@react-navigation/native';
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { View, useWindowDimensions } from 'react-native'; import { View, useWindowDimensions } from 'react-native';
import type { ViewStyleProp } from 'react-native/Libraries/StyleSheet/StyleSheet'; import type { ViewStyleProp } from 'react-native/Libraries/StyleSheet/StyleSheet';
import { FlatList } from 'react-native-gesture-handler'; import { FlatList } from 'react-native-gesture-handler';
import { useFetchThreadMedia } from 'lib/actions/thread-actions.js'; import { useFetchThreadMedia } from 'lib/actions/thread-actions.js';
import type { MediaInfo, Media } from 'lib/types/media-types'; import type { MediaInfo, Media } from 'lib/types/media-types';
import { import {
ThreadSettingsCategoryActionHeader, ThreadSettingsCategoryActionHeader,
ThreadSettingsCategoryFooter, ThreadSettingsCategoryFooter,
} from './thread-settings-category.react.js'; } from './thread-settings-category.react.js';
import GestureTouchableOpacity from '../../components/gesture-touchable-opacity.react.js'; import GestureTouchableOpacity from '../../components/gesture-touchable-opacity.react.js';
import type { ImageModalParams } from '../../media/image-modal.react.js';
import Multimedia from '../../media/multimedia.react.js'; import Multimedia from '../../media/multimedia.react.js';
import type { VideoPlaybackModalParams } from '../../media/video-playback-modal.react.js';
import { import {
ImageModalRouteName, ImageModalRouteName,
VideoPlaybackModalRouteName, VideoPlaybackModalRouteName,
} from '../../navigation/route-names.js'; } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
import type { import type {
LayoutCoordinates, LayoutCoordinates,
VerticalBounds, VerticalBounds,
▲ Show 20 Lines • Show All 196 Lines • ▼ Show 20 Lines const navigateToMedia = React.useCallback(() => {
ref.current?.measure((x, y, width, height, pageX, pageY) => { ref.current?.measure((x, y, width, height, pageX, pageY) => {
const initialCoordinates: LayoutCoordinates = { const initialCoordinates: LayoutCoordinates = {
x: pageX, x: pageX,
y: pageY, y: pageY,
width, width,
height, height,
}; };
invariant(
verticalBounds,
'verticalBounds should be set in navigateToMedia',
);
const params: ImageModalParams | VideoPlaybackModalParams = {
presentedFrom: route.key,
mediaInfo,
initialCoordinates,
verticalBounds,
};
navigation.navigate<'VideoPlaybackModal' | 'ImageModal'>({ navigation.navigate<'VideoPlaybackModal' | 'ImageModal'>({
name: name:
mediaInfo.type === 'video' || mediaInfo.type === 'encrypted_video' mediaInfo.type === 'video' || mediaInfo.type === 'encrypted_video'
? VideoPlaybackModalRouteName ? VideoPlaybackModalRouteName
: ImageModalRouteName, : ImageModalRouteName,
key: `multimedia|${threadID}|${mediaInfo.id}`, key: `multimedia|${threadID}|${mediaInfo.id}`,
params: { params,
presentedFrom: route.key,
mediaInfo,
item,
initialCoordinates,
verticalBounds,
},
}); });
}); });
}, [navigation, route, threadID, mediaInfo, item, verticalBounds]); }, [navigation, route, threadID, mediaInfo, verticalBounds]);
const containerStyle = const containerStyle =
index % numColumns === 0 index % numColumns === 0
? memoizedStyles.mediaContainer ? memoizedStyles.mediaContainer
: memoizedStyles.mediaContainerWithMargin; : memoizedStyles.mediaContainerWithMargin;
return ( return (
<View key={item.id} style={containerStyle} onLayout={onLayout} ref={ref}> <View key={item.id} style={containerStyle} onLayout={onLayout} ref={ref}>
Show All 25 Lines