Page MenuHomePhabricator
Differential D14464

[keyserver] call `free()` on Olm objects in finally block
ClosedPublic
Actions

Authored by kamil on Wed, Mar 19, 10:03 AM.
Tags
None
Referenced Files
F5261650: D14464.diff
Sun, Apr 6, 3:32 PM
F5253894: D14464.id47493.diff
Sun, Apr 6, 6:48 AM
F5251490: D14464.id47474.diff
Sun, Apr 6, 4:19 AM
F5251275: D14464.id47506.diff
Sun, Apr 6, 4:09 AM
Unknown Object (File)
Thu, Apr 3, 5:03 AM
Unknown Object (File)
Wed, Apr 2, 10:32 PM
Unknown Object (File)
Wed, Apr 2, 10:32 PM
Unknown Object (File)
Wed, Apr 2, 10:35 AM
View All 33 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
ashoat
Commits
rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block
Summary

Some context in ENG-10393

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
leaks
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Mar 19, 10:03 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Mar 19, 10:03 AM
ashoat published this revision for review.Wed, Mar 19, 10:06 AM
ashoat added inline comments.
keyserver/src/utils/olm-objects.js
30

Don’t need to declare here

32

Can be const result here

80

Same here

ashoat accepted this revision.Wed, Mar 19, 10:06 AM
This revision is now accepted and ready to land.Wed, Mar 19, 10:06 AM
Harbormaster completed remote builds in B33770: Diff 47474.Wed, Mar 19, 10:33 AM
bartek accepted this revision.Wed, Mar 19, 11:56 AM
kamil updated this revision to Diff 47493.Thu, Mar 20, 4:58 AM

review comments

kamil added a child revision: D14482: [web] clear old `cryptoStore` before creating new one.Thu, Mar 20, 4:59 AM
Harbormaster completed remote builds in B33789: Diff 47493.Thu, Mar 20, 5:29 AM
Closed by commit rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block (authored by kamil). · Explain WhyThu, Mar 20, 6:21 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM4765e9c616eb: [keyserver] call `free()` on Olm objects in finally block.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
39 lines

Diff 47474

View Options

keyserver/src/utils/olm-objects.js

FROM rust:1.70-bullseye as builder FROM rust:1.70-bullseye as builder
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \ build-essential cmake git libgtest-dev libssl-dev zlib1g-dev \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
WORKDIR /home/root/app/backup WORKDIR /home/root/app/backup
# Install more recent version of protobuf, must be ran as root # Install more recent version of protobuf, must be ran as root
COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh COPY scripts/install_protobuf.sh ../../scripts/install_protobuf.sh
RUN ../../scripts/install_protobuf.sh RUN ../../scripts/install_protobuf.sh
ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse
# Copy actual application sources # Copy actual application sources
COPY shared ../../shared/ COPY shared ../../shared/
COPY services/comm-services-lib ../comm-services-lib
COPY services/backup ./ COPY services/backup ./
RUN cargo install --locked --path . RUN cargo install --locked --path .
# Runner stage # Runner stage
FROM debian:bullseye-slim as runner FROM debian:bullseye-slim as runner
# Update dependencies, install ca-certificates which are required for TLS # Update dependencies, install ca-certificates which are required for TLS
Show All 15 Lines