We were confirming a message only if a condition is met, but there's no good reason to do so: if we were able to decrypt and process a message, we can confirm it. This should reduce the chance of receiving the same message again.
Depends on D14756
Details
Details
Flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/tunnelbroker/peer-to-peer-message-handler.js | ||
|---|---|---|
| 87 ↗ | (On Diff #48275) | I would remove only this line, still worth checking if doesSocketExist because if not, socketSend fails anyway but shouldn't really matter |