[native] Pass generateBackupDataKey to Rust
ClosedPublic
Actions

Authored by bartek on Jun 2 2025, 10:52 AM.

Details

Reviewers

kamil

Commits

rCOMMd853ccb7d92e: [native] Pass generateBackupDataKey to Rust

Summary

Part of ENG-10519.
We want to call generateBackupDataKey() and generateBackupLogDataKey() from Rust, but we don't want to update CommSecureStore values there.

Test Plan

Native builds, tested in later diffs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 2 2025, 10:52 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 2 2025, 10:52 AM

bartek added a child revision: D14797: [native] Update Rust functions to use random backup keys.Jun 2 2025, 10:56 AM

Harbormaster completed remote builds in B34340: Diff 48387.Jun 2 2025, 11:20 AM

bartek published this revision for review.Jun 2 2025, 11:31 AM

bartek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp
169–176 ↗	(On Diff #48387)	My refactor idea for this is as follows: Move `backupDataKeySize` constants somewhere else, e.g. `SQLiteBackup` and make them public Create ephemeral `generateRandomBackupDataKey()` in `SQLiteBackup` or Utils Call it from here (`DatabaseManager`) and update secure store Call it from Rust in BackupOperationsExecutor The same for logs key
native/native_rust_library/src/lib.rs
582 ↗	(On Diff #48387)	Fix clippy warning