Paths

Table of Contentst

Differential D14834

[native] Add primary device check to DatabaseManager
ClosedPublic
Actions

Authored by bartek on Jun 12 2025, 10:18 AM.

Details

Reviewers

kamil

Commits

rCOMMa84ee33b1bdf: [native] Add primary device check to DatabaseManager

Summary

Address ENG-8227.
Created C++ method to determine if we're running DB operations on a primary device.

Depends on D14833

Test Plan

Used Xcode debugger to verify that the function works as expected. Tested primary and secondary device.
Made sure logs are not captured on secondary device

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 12 2025, 10:18 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 12 2025, 10:18 AM

Harbormaster failed remote builds in B34396: Diff 48476!Jun 12 2025, 10:29 AM

bartek added a child revision: D14837: [native] Rename C++ functions for logs.Jun 12 2025, 12:58 PM

Harbormaster completed remote builds in B34396: Diff 48476.Jun 12 2025, 1:33 PM

bartek published this revision for review.Jun 12 2025, 2:51 PM

bartek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp
261–263 ↗	(On Diff #48476)	Checking this with every log is expensive. This is later improved in D14838

Add overload

Harbormaster failed remote builds in B34412: Diff 48500!Jun 16 2025, 6:39 AM

Harbormaster completed remote builds in B34412: Diff 48500.Jun 16 2025, 7:24 AM

kamil accepted this revision.Jun 18 2025, 2:23 PM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp
482	It's not clear why we need those two, but maybe it will be clear later in the stack, but it is still fine
514	Is `\n\t` needed here?

This revision is now accepted and ready to land.Jun 18 2025, 2:23 PM

kamil mentioned this in D14838: [native] Improve logs monitoring management.Jun 18 2025, 2:35 PM

bartek added inline comments.Jul 2 2025, 9:09 AM

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp
514	It was primarily for brevity, but I'll revert it to keep consistency with other places

Closed by commit rCOMMa84ee33b1bdf: [native] Add primary device check to DatabaseManager. · Explain WhyJul 2 2025, 10:14 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa84ee33b1bdf: [native] Add primary device check to DatabaseManager.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseManager.h

3 lines

DatabaseManager.cpp

60 lines

Diff 48500

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.h