[web][native] handle QueuedDMOperations for the backup
ClosedPublic
Actions

Authored by kamil on Jul 29 2025, 12:36 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM2e3e54901ef4: [web][native] handle QueuedDMOperations for the backup

Summary

ENG-11029.

Depends on D15160

Test Plan

Tests and test restore, test logs

Diff Detail

Repository

rCOMM Comm

Branch

publish-que

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 29 2025, 12:36 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 29 2025, 12:36 PM

kamil retitled this revision from [web][native] Handle QueuedDMOperations for the backup to [web][native] handle QueuedDMOperations for the backup.Jul 29 2025, 12:53 PM

Harbormaster completed remote builds in B35031: Diff 49253.Jul 29 2025, 1:22 PM

kamil published this revision for review.Jul 29 2025, 1:23 PM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1737–1739 ↗	(On Diff #49253)	We couldn't use `std::erase(tableNames, std::string("queued_dm_operations"));` because it requires C++20

kamil edited the test plan for this revision. (Show Details)Jul 29 2025, 1:24 PM

ashoat added inline comments.Jul 29 2025, 1:32 PM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1737–1739 ↗	(On Diff #49253)	Good news – it looks like C++20 support might be coming with the React Native upgrade! D14976 (Just a note, I don't feel like you need a follow-up task or anything)