[SQLite] implement queries for QueuedDMOperations
ClosedPublic
Actions

Authored by kamil on Jul 29 2025, 11:35 AM.

Details

Reviewers

tomek

Commits

rCOMM3c8b5abe22b2: [SQLite] implement queries for QueuedDMOperations

Summary

ENG-10708.

We need SQLiteQueuedDMOperation to be able to use the correct value in the table and avoid passing long numbers across different platforms; string is safer for that purpose.

Depends on D15149

Test Plan

Tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 29 2025, 11:35 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 29 2025, 11:35 AM

kamil removed a reviewer: bartek.Jul 29 2025, 11:36 AM

kamil added a child revision: D15151: [lib] implement tests to QueuedDMOperations reducer.Jul 29 2025, 11:37 AM

Harbormaster completed remote builds in B35020: Diff 49242.Jul 29 2025, 11:53 AM

kamil published this revision for review.Jul 29 2025, 12:58 PM

kamil edited the summary of this revision. (Show Details)

tomek accepted this revision.Jul 30 2025, 1:00 PM

tomek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/entities/QueuedDMOperation.h
28–38 ↗	(On Diff #49242)	If we write multiple times to the same variable, we can override an error with `0`. Shouldn't we return immediately after getting an error?
81 ↗	(On Diff #49242)	Newline