Paths

Table of Contentst

Differential D15254

[lib] implement changing thread unread status for Farcaster threads
ClosedPublic
Actions

Authored by kamil on Aug 27 2025, 3:28 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM669a4a7ef151: [lib] implement changing thread unread status for Farcaster threads

Summary

Depends on D15253, D15249

Test Plan

Test marking thread as read and unread and confirm with Farcaster app that it works.

Diff Detail

Repository

Branch

unreads

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 27 2025, 3:28 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 27 2025, 3:28 PM

update

Harbormaster failed remote builds in B35558: Diff 50039!Aug 27 2025, 3:31 PM

kamil published this revision for review.Aug 27 2025, 3:34 PM

kamil added inline comments.

lib/shared/farcaster/farcaster-api.js
328–329 ↗	(On Diff #50040)	`apiVersion` - is currently unused for `STREAM` `endpoint` - this is also unused, but I set it to the same value as `messageType`

Harbormaster failed remote builds in B35559: Diff 50040!Aug 27 2025, 3:37 PM

kamil mentioned this in D15258: [lib] Refresh Farcaster threads after opening a thread.Aug 28 2025, 9:36 AM

tomek accepted this revision.Aug 28 2025, 10:06 AM

This revision is now accepted and ready to land.Aug 28 2025, 10:06 AM

rebase

Harbormaster failed remote builds in B35577: Diff 50079!Aug 28 2025, 2:14 PM

This revision was landed with ongoing or failed builds.Aug 28 2025, 2:49 PM

Closed by commit rCOMM669a4a7ef151: [lib] implement changing thread unread status for Farcaster threads. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM669a4a7ef151: [lib] implement changing thread unread status for Farcaster threads.

Revision Contents
Changeset List

Path

Size

lib/

actions/

activity-actions.js

16 lines

shared/

farcaster/

farcaster-api.js

51 lines

threads/

protocols/

farcaster-thread-protocol.js

25 lines

4 lines

Diff 50079

lib/actions/activity-actions.js

Loading...

lib/shared/farcaster/farcaster-api.js

Loading...

lib/shared/threads/protocols/farcaster-thread-protocol.js

Loading...

lib/shared/threads/thread-spec.js

Loading...