[lib] update and simplify changing thread settings
ClosedPublic
Actions

Authored by kamil on Sep 8 2025, 12:06 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM8d82cad541e8: [lib] update and simplify changing thread settings

Summary

ENG-10929

Added updating thread members as part of changing the thread setting
Avoided code duplications and used the same approach with a refreshing conversation as in other methods

Depends on D15303

Test Plan

Test changing thread settings on web and native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 8 2025, 12:06 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 8 2025, 12:06 PM

kamil edited the summary of this revision. (Show Details)Sep 8 2025, 12:08 PM

kamil published this revision for review.Sep 8 2025, 12:28 PM

Harbormaster completed remote builds in B35650: Diff 50195.Sep 8 2025, 12:30 PM

kamil added a child revision: D15305: [lib] remove dead threads when fetching inbox.Sep 8 2025, 1:43 PM

tomek accepted this revision.Sep 9 2025, 5:38 PM

tomek added inline comments.

lib/shared/threads/protocols/farcaster-thread-protocol.js
188–191 ↗	(On Diff #50195)	Should this be extracted to a util function?

This revision is now accepted and ready to land.Sep 9 2025, 5:38 PM

kamil added inline comments.Sep 10 2025, 3:08 PM

lib/shared/threads/protocols/farcaster-thread-protocol.js
188–191 ↗	(On Diff #50195)	I'll do it as a follow-up and link the diff later

This revision was landed with ongoing or failed builds.Sep 10 2025, 3:42 PM

Closed by commit rCOMM8d82cad541e8: [lib] update and simplify changing thread settings. · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM8d82cad541e8: [lib] update and simplify changing thread settings.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

thread-hooks.js

26 lines

shared/

threads/

protocols/

farcaster-thread-protocol.js

79 lines

thread-spec.js

14 lines

Diff 50214

View Options

lib/hooks/thread-hooks.js

View Options

lib/shared/threads/protocols/farcaster-thread-protocol.js

View Options

lib/shared/threads/thread-spec.js

[lib] update and simplify changing thread settingsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50214

lib/hooks/thread-hooks.js

lib/shared/threads/protocols/farcaster-thread-protocol.js

lib/shared/threads/thread-spec.js

[lib] update and simplify changing thread settings
ClosedPublic
Actions

Revision Contents
Changeset List