[lib] Fetch all the inbox types
ClosedPublic
Actions

Authored by tomek on Sep 10 2025, 6:08 PM.

Details

Reviewers

kamil
bartek

Commits

rCOMMaac606be6b41: [lib] Fetch all the inbox types

Summary

We should additionally fetch archived and request inbox categories.

https://linear.app/comm/issue/ENG-11189/handle-conversation-requests

Test Plan

Checked if the requests also were fetched. The problem with them is that fetching messages fails for them because of Not authorized to access this conversation error. It is expected and we should handle fetching the messages again after joining a thread https://linear.app/comm/issue/ENG-11186/fetch-all-the-messages-when-a-user-is-added-to-a-thread.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 10 2025, 6:08 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 10 2025, 6:08 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 10 2025, 6:19 PM

Harbormaster failed remote builds in B35665: Diff 50217!

tomek added a child revision: D15313: [lib] Block tooltip actions for creating sidebars.Sep 10 2025, 6:56 PM

tomek requested review of this revision.Sep 10 2025, 7:15 PM

kamil accepted this revision.Sep 11 2025, 10:14 AM

This revision is now accepted and ready to land.Sep 11 2025, 10:14 AM

Is it okay to fetch it before we implement joining them? I think this might be confusing

In D15312#421885, @kamil wrote:

Is it okay to fetch it before we implement joining them? I think this might be confusing

Makes sense! Let's wait with landing this for the proper solution to https://linear.app/comm/issue/ENG-11189/handle-conversation-requests

tomek removed a parent revision: D15311: [lib] Improve Farcaster sync by handling messages and conversations together.Sep 11 2025, 12:58 PM

tomek removed a child revision: D15313: [lib] Block tooltip actions for creating sidebars.

tomek edited the summary of this revision. (Show Details)

Remove fetching other categories, but keep an option to do so

This revision is now accepted and ready to land.Sep 15 2025, 10:30 AM

In D15312#421923, @tomek wrote:

In D15312#421885, @kamil wrote:

Is it okay to fetch it before we implement joining them? I think this might be confusing

Makes sense! Let's wait with landing this for the proper solution to https://linear.app/comm/issue/ENG-11189/handle-conversation-requests