Paths

Table of Contentst

[lib] Improve Farcaster sync by handling messages and conversations together
ClosedPublic
Actions

Authored by tomek on Sep 10 2025, 12:35 PM.

Details

Reviewers

kamil
bartek

Commits

rCOMM553a34d0441c: [lib] Improve Farcaster sync by handling messages and conversations together

Summary

This makes the loading progress less confusing and allows correctly setting the truncation status.

Depends on D15310

Test Plan

Checked if the sync works correctly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 10 2025, 12:35 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 10 2025, 12:35 PM

tomek added inline comments.Sep 10 2025, 12:35 PM

lib/shared/farcaster/farcaster-hooks.js
394 ↗	(On Diff #50210)	Farcaster uses this value when fetching messages

tomek edited the summary of this revision. (Show Details)Sep 10 2025, 12:38 PM

Harbormaster completed remote builds in B35662: Diff 50210.Sep 10 2025, 12:54 PM

tomek requested review of this revision.Sep 10 2025, 12:54 PM

tomek added a child revision: D15312: [lib] Fetch all the inbox types.Sep 10 2025, 6:08 PM

kamil accepted this revision.Sep 11 2025, 10:12 AM

kamil added inline comments.

lib/shared/farcaster/farcaster-hooks.js
207 ↗	(On Diff #50210)	You can avoid `any`

This revision is now accepted and ready to land.Sep 11 2025, 10:12 AM

Avoid any

tomek removed a child revision: D15312: [lib] Fetch all the inbox types.Sep 11 2025, 12:58 PM

tomek added a child revision: D15313: [lib] Block tooltip actions for creating sidebars.

Harbormaster failed remote builds in B35689: Diff 50242!Sep 11 2025, 1:07 PM

This revision was landed with ongoing or failed builds.Sep 11 2025, 2:00 PM

Closed by commit rCOMM553a34d0441c: [lib] Improve Farcaster sync by handling messages and conversations together. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM553a34d0441c: [lib] Improve Farcaster sync by handling messages and conversations together.

Revision Contents
Changeset List

Path

Size

lib/

shared/

farcaster/

farcaster-hooks.js

258 lines

native/

farcaster/

farcaster-sync-loading-screen.react.js

12 lines

web/

farcaster/

farcaster-sync-loading-screen.react.js

6 lines

Diff 50248

View Options

lib/shared/farcaster/farcaster-hooks.js

View Options

native/farcaster/farcaster-sync-loading-screen.react.js

View Options

web/farcaster/farcaster-sync-loading-screen.react.js

[lib] Improve Farcaster sync by handling messages and conversations togetherClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50248

lib/shared/farcaster/farcaster-hooks.js

native/farcaster/farcaster-sync-loading-screen.react.js

web/farcaster/farcaster-sync-loading-screen.react.js

[lib] Improve Farcaster sync by handling messages and conversations together
ClosedPublic
Actions

Revision Contents
Changeset List