[tunnelbroker] spawn new tokio task for each Farcaster request
ClosedPublic
Actions

Authored by kamil on Sep 5 2025, 9:43 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMMc48fe56b39b9: [tunnelbroker] spawn new tokio task for each Farcaster request

Summary

This come up in discussion with @tomek, another place where we can speed things up.

Test Plan

I send this diff to @tomek and he tested this locally

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 5 2025, 9:43 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 5 2025, 9:44 AM

kamil published this revision for review.Sep 5 2025, 9:55 AM

kamil edited the test plan for this revision. (Show Details)

With these changes, I noticed a big improvement in how long the sync takes. In my test case, these changes alone reduced the duration from 23.5s to 14s. Additionally, these make batch processing a lot more efficient - with batch size = 20 the processing time dropped to 6s. (This test case was to sync 39 Farcaster threads with a limit of 20 messages per thread.)

Harbormaster completed remote builds in B35641: Diff 50179.Sep 5 2025, 10:04 AM

tomek added a child revision: D15299: [lib] Improve Farcaster sync performance.Sep 5 2025, 10:47 AM

Nice, the handle_websocket_farcaster_request_static() refactor could probably be handled in a more idiomatic way, but this is okay too

This revision is now accepted and ready to land.Sep 5 2025, 12:52 PM

Closed by commit rCOMMc48fe56b39b9: [tunnelbroker] spawn new tokio task for each Farcaster request. · Explain WhySep 5 2025, 1:28 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMc48fe56b39b9: [tunnelbroker] spawn new tokio task for each Farcaster request.