[lib] Optimistically create a reaction
ClosedPublic
Actions

Authored by tomek on Sep 12 2025, 7:24 PM.

Details

Reviewers

kamil
bartek

Commits

rCOMM2c3781d3be0f: [lib] Optimistically create a reaction

Summary

Update or create a compound reaction

https://linear.app/comm/issue/ENG-11246/handle-optimistic-reaction-creation

Depends on D15336

Test Plan

Tested that both reacting and unreacting result in an optimistic update and an update in the Farcaster app.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 12 2025, 7:24 PM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 12 2025, 7:24 PM

tomek published this revision for review.Sep 12 2025, 7:24 PM

Harbormaster failed remote builds in B35705: Diff 50269!Sep 12 2025, 7:40 PM

Bump the timestamp and rebase

Harbormaster failed remote builds in B35738: Diff 50315!Sep 15 2025, 11:34 AM

kamil accepted this revision.Sep 15 2025, 1:38 PM

This revision is now accepted and ready to land.Sep 15 2025, 1:38 PM

tomek added a child revision: D15374: [lib] Avoid receiving COMPOUND_REACTION messages on older clients.Sep 18 2025, 10:33 AM

This revision was landed with ongoing or failed builds.Sep 18 2025, 1:09 PM

Closed by commit rCOMM2c3781d3be0f: [lib] Optimistically create a reaction. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM2c3781d3be0f: [lib] Optimistically create a reaction.

Revision Contents
Changeset List

Path

Size

lib/

shared/

reaction-utils.js

28 lines

threads/

protocols/

dm-thread-protocol.js

6 lines

farcaster-thread-protocol.js

54 lines

keyserver-thread-protocol.js

6 lines

thread-spec.js

6 lines

types/

message-types.js

12 lines

utils/

convert-farcaster-message-to-comm-messages.js

8 lines

native/

chat/

inline-engagement.react.js

2 lines

multimedia-message-tooltip-button.react.js

2 lines

reaction-message-utils.js

5 lines

robotext-message-tooltip-button.react.js

2 lines

text-message-tooltip-button.react.js

2 lines

web/

chat/

inline-engagement.react.js

4 lines

reaction-message-utils.js

10 lines

reaction-pill.react.js

7 lines

tooltips/

message-tooltip.react.js

2 lines

Diff 50269

View Options

lib/shared/reaction-utils.js

View Options

lib/shared/threads/protocols/dm-thread-protocol.js

View Options

lib/shared/threads/protocols/farcaster-thread-protocol.js

View Options

lib/shared/threads/protocols/keyserver-thread-protocol.js

View Options

lib/shared/threads/thread-spec.js

View Options

lib/types/message-types.js

View Options

lib/utils/convert-farcaster-message-to-comm-messages.js

View Options

native/chat/inline-engagement.react.js

View Options

native/chat/multimedia-message-tooltip-button.react.js

View Options

native/chat/reaction-message-utils.js

View Options

native/chat/robotext-message-tooltip-button.react.js

View Options

native/chat/text-message-tooltip-button.react.js

View Options

web/chat/inline-engagement.react.js

View Options

web/chat/reaction-message-utils.js

View Options

web/chat/reaction-pill.react.js

View Options

web/tooltips/message-tooltip.react.js

[lib] Optimistically create a reactionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50269

lib/shared/reaction-utils.js

lib/shared/threads/protocols/dm-thread-protocol.js

lib/shared/threads/protocols/farcaster-thread-protocol.js

lib/shared/threads/protocols/keyserver-thread-protocol.js

lib/shared/threads/thread-spec.js

lib/types/message-types.js

lib/utils/convert-farcaster-message-to-comm-messages.js

native/chat/inline-engagement.react.js

native/chat/multimedia-message-tooltip-button.react.js

native/chat/reaction-message-utils.js

native/chat/robotext-message-tooltip-button.react.js

native/chat/text-message-tooltip-button.react.js

web/chat/inline-engagement.react.js

web/chat/reaction-message-utils.js

web/chat/reaction-pill.react.js

web/tooltips/message-tooltip.react.js

[lib] Optimistically create a reaction
ClosedPublic
Actions

Revision Contents
Changeset List