Refactoring codebase to switch from ...Id to ...ID in the variables, methods, functions.
Linear task: ENG-617
Details
Details
Successfully built tunnelbroker server after refactoring.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- @max/@karol/tunnelbroker-newstack
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
I'm not sure what is wrong here... I cannot patch this diff, @geekbrother can you make it patchable? Maybe rebase it to master or something? For diffs like this where there isn't really a logic to verify, it's very useful to be able to patch it to the local environment and use the local IDE to analyze the changes.
| services/tunnelbroker/docker-server/contents/server/src/Database/DeviceSessionItem.cpp | ||
|---|---|---|
| 8–9 ↗ | (On Diff #9422) | Can we update these without any migration on the working instance? Do we need to clean something up on the instances? |
| services/tunnelbroker/docker-server/contents/server/src/Database/DeviceSessionItem.cpp | ||
|---|---|---|
| 8–9 ↗ | (On Diff #9422) |
Good catch @palys-swm ! I've removed changes of the table names and created a separate task as we need to consider the migration procedure for that. |
Comment Actions
This build fails, but my guess is that rebasing on master should fix the issue
| services/tunnelbroker/docker-server/contents/server/src/Database/DeviceSessionItem.cpp | ||
|---|---|---|
| 8–9 ↗ | (On Diff #9422) | We don't necessarily need a migration. We can probably just recreate a couple of things, as we probably don't store anything important there yet - but we need to think about what needs to be done and cleaned. |
Comment Actions
I don't understand why the build failed. It looks like the CI is green, and @geekbrother recently rebased. Is it possible that this diff is leading to a build failure? @geekbrother, can you look into it?
Comment Actions
I've rechecked it before it builds locally.
The build success now after rebasing.
Not sure it was the CI, other services, or rebasing issue, but it is successful now.
| services/tunnelbroker/docker-server/contents/server/src/Database/DeviceSessionItem.cpp | ||
|---|---|---|
| 8–9 ↗ | (On Diff #9422) |
Yes, I think this is for another small diff and tracked by this task. |
Comment Actions
Didn't have time to actually review it... assuming @geekbrother has been thorough in checking all of the sites. Might be good to grep around for places to migrate one last time after rebasing and before landing!