Page MenuHomePhabricator

[web] [feat] thread menu button hoverable
ClosedPublic

Authored by benschac on Feb 3 2022, 12:51 PM.
Tags
None
Referenced Files
F3309142: D3099.diff
Tue, Nov 19, 4:27 AM
Unknown Object (File)
Sat, Nov 2, 4:01 AM
Unknown Object (File)
Oct 15 2024, 7:49 AM
Unknown Object (File)
Oct 13 2024, 12:01 PM
Unknown Object (File)
Oct 13 2024, 12:01 PM
Unknown Object (File)
Oct 13 2024, 12:01 PM
Unknown Object (File)
Oct 13 2024, 12:00 PM
Unknown Object (File)
Oct 7 2024, 6:57 AM

Details

Summary

remove menu button for threads

updated with hover:

Screen Recording 2022-02-08 at 10.33.10 AM.gif (300×482 px, 253 KB)

note: arrow positioning updated in future diffs.

Test Plan

should render, look like screen shot

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested changes to this revision.Feb 3 2022, 8:05 PM

Wait, does this make it impossible to mark a thread as unread? We definitely shouldn't lose that. Maybe we can make it appear on hover?

This revision now requires changes to proceed.Feb 3 2022, 8:05 PM

That's fair. Let's make it appear on hover.

benschac retitled this revision from [web] [remove] thread menu button to [web] [feat] thread menu button hoverable.Feb 8 2022, 7:44 AM
benschac edited the summary of this revision. (Show Details)
atul added inline comments.
web/chat/chat-thread-list.css
125–130

Probably overkill and don't recommend making this change...

but since divs are display: block by default, I think we could do something like this:

div.sidebar:not(:hover) .menu {
  display: none;
}
This revision is now accepted and ready to land.Feb 8 2022, 8:11 PM