So we can hit SessionSignature(...) endpoint
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/cpp/CommonCpp/grpc/Client.cpp | ||
---|---|---|
138 ↗ | (On Diff #9416) | So what's going on here... NULL is a c-str and that get initialized into an std::string? Is this the best pattern? |
native/cpp/CommonCpp/grpc/Client.cpp | ||
---|---|---|
138 ↗ | (On Diff #9416) | Just kidding... Looks like the right thing to do is return std::string{}; and check for empty string if (blah.empty()) { return; } |
native/cpp/CommonCpp/grpc/Client.cpp | ||
---|---|---|
138 ↗ | (On Diff #9416) | Alternatively I guess could return a std::optional<std::string>> or tuple of (grpc::Status, std::optional<std::string>) or something |