Paths

Table of Contentst

[CommCoreModule] Add `sessionSignature` & `newSession` boilerplate to `NetworkModule`
ClosedPublic
Actions

Authored by atul on Feb 9 2022, 1:14 PM.

Details

Reviewers

ashoat
• jacek
varun
tomek
• karol
• jim

Commits

rCOMM0ae429c073d6: [CommCoreModule] Add `sessionSignature` & `newSession` boilerplate to…

Summary

NA, boilerplate (should've been squashed with previous Client diffs)

Test Plan

Continues to build, able to call

Diff Detail

Repository

rCOMM Comm

Branch

landfeb10 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 9 2022, 1:14 PM

Herald added subscribers: • benschac, • adrian. · View Herald TranscriptFeb 9 2022, 1:14 PM

atul edited the summary of this revision. (Show Details)Feb 9 2022, 1:15 PM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B6694: Diff 9497.Feb 9 2022, 1:20 PM

atul requested review of this revision.Feb 9 2022, 1:20 PM

ashoat accepted this revision.Feb 9 2022, 10:09 PM

ashoat added a reviewer: • jim.

This revision is now accepted and ready to land.Feb 9 2022, 10:09 PM

rebase before landing

Harbormaster completed remote builds in B6715: Diff 9527.Feb 10 2022, 6:57 AM

Closed by commit rCOMM0ae429c073d6: [CommCoreModule] Add `sessionSignature` & `newSession` boilerplate to… (authored by atul). · Explain WhyFeb 10 2022, 6:59 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0ae429c073d6: [CommCoreModule] Add `sessionSignature` & `newSession` boilerplate to….

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

InternalModules/

NetworkModule.h

10 lines

NetworkModule.cpp

28 lines

Diff 9527

View Options

native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.h