Added Members and Sidebars menu items, that are displayed conditionally.
The onClick functionality will be added in one of next diffs.
Details
Details
Checked if Sidebar item appears correclty after adding sidebars to thread, and if Memberes is not displayed in Personal threads.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
web/chat/thread-menu.react.js | ||
---|---|---|
65–68 ↗ | (On Diff #9600) | This is correct, but we can consider avoiding repetition here by defining items outside the memo. The proposed approach has an unexpected usage of dependency array, which is defined earlier, so it might be confusing... not sure if it's worth it. |