Page MenuHomePhabricator

[CommCoreModule] Introduce `CommCoreModule::setNotifyToken`
ClosedPublic

Authored by atul on Feb 10 2022, 6:06 PM.
Tags
None
Referenced Files
F3408489: D3171.id9551.diff
Wed, Dec 4, 11:35 AM
F3408480: D3171.id9625.diff
Wed, Dec 4, 11:32 AM
F3408476: D3171.id9622.diff
Wed, Dec 4, 11:30 AM
F3406796: D3171.id9625.diff
Wed, Dec 4, 3:27 AM
F3406794: D3171.id.diff
Wed, Dec 4, 3:27 AM
F3406781: D3171.id9622.diff
Wed, Dec 4, 3:26 AM
F3406778: D3171.id9551.diff
Wed, Dec 4, 3:25 AM
F3406691: D3171.diff
Wed, Dec 4, 3:05 AM

Details

Summary

Stores notifyToken value in the SQLite metadata table

Test Plan
  1. Call the function
  2. Verify that the row was created in the SQLite DB

https://blob.sh/atul/50fb.png

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Feb 10 2022, 6:11 PM

@atul, you've gotten into a "default mode" of adding me as a reviewer to your diffs when you create them. That was meant as a short-term fix to get your Tunnelbroker work out ASAP, but at this point that work has dragged on for weeks. This isn't meant to be a new default, so let's get back to the consistent, disciplined approach of having a first round of review before passing it to me

This revision is now accepted and ready to land.Feb 11 2022, 2:34 AM
This revision now requires review to proceed.Feb 11 2022, 2:34 AM
ashoat added a reviewer: jim.
This revision is now accepted and ready to land.Feb 13 2022, 8:10 PM

so let's get back to the consistent, disciplined approach of having a first round of review before passing it to me

Gotcha, will do