This replaces the services_config.sh script.
https://linear.app/comm/issue/ENG-778/use-docker-compose-environment-file
Paths
| Differential D3233 Authored by • jim on Feb 16 2022, 12:09 PM.
Tags None Referenced Files
Subscribers
Details Summary This replaces the services_config.sh script. https://linear.app/comm/issue/ENG-778/use-docker-compose-environment-file Test Plan Run launch scripts
Diff Detail
Event TimelineHerald added subscribers: • benschac, atul, • adrian, tomek. · View Herald TranscriptFeb 16 2022, 12:09 PM2022-02-16 12:09:04 (UTC-8) • jim edited the summary of this revision. (Show Details)Feb 16 2022, 12:10 PM2022-02-16 12:10:02 (UTC-8) Harbormaster completed remote builds in B6899: Diff 9750.Feb 16 2022, 12:13 PM2022-02-16 12:13:32 (UTC-8) Comment Actions I checked and it works. How does this work? Does docker-compose automatically sources .env file? Looks like it but correct me if I'm wrong. This is cool, I didn't know about this! Passing back to your queue to get answers but the idea looks great!
This revision now requires changes to proceed.Feb 18 2022, 6:29 AM2022-02-18 06:29:16 (UTC-8) Comment Actions Yes, it doesn't actually source into environment variables but parses it as a file. So if you actually set the environment variables, they will override whatever is in the file. And for different configurations you can pass the --env-file flag explicitly. See https://docs.docker.com/compose/env-file/.
Comment Actions @jimpo, when responding to "Request changes" you should select "Re-request review" from the dropdown at the bottom. That way the diff goes to your reviewer's queue again, instead of being stuck on your queue. (This is why the status of the diff is currently "Needs Revision".)
This revision is now accepted and ready to land.Feb 25 2022, 12:27 AM2022-02-25 00:27:10 (UTC-8) Herald added 1 blocking reviewer(s): ashoat. · View Herald TranscriptFeb 25 2022, 12:27 AM2022-02-25 00:27:11 (UTC-8) This revision now requires review to proceed.Feb 25 2022, 12:27 AM2022-02-25 00:27:11 (UTC-8) This revision is now accepted and ready to land.Feb 25 2022, 12:38 PM2022-02-25 12:38:24 (UTC-8) Closed by commit rCOMM90ddba6307b1: services: Use .env file for docker-compose (authored by • jim). · Explain WhyFeb 25 2022, 2:38 PM2022-02-25 14:38:24 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 9750 services/.env
services/scripts/build_base_image.sh
services/scripts/run_all_services.sh
services/scripts/run_server_image.sh
|
This automatically inserts the new item into the secondary index, right?