Paths

Table of Contentst

Differential D3261

[web, native] Introduce and use `ThreadIsChannel` function
ClosedPublic
Actions

Authored by • jacek on Feb 22 2022, 4:49 AM.

Tags

None

Referenced Files

	F3274031: D3261.id9805.diff
	Sat, Nov 16, 6:25 AM

	F3273977: D3261.id10008.diff
	Sat, Nov 16, 6:24 AM

	Unknown Object (File)
	Wed, Nov 13, 12:32 PM

	Unknown Object (File)
	Sat, Nov 2, 6:37 AM

	Unknown Object (File)
	Sat, Nov 2, 6:37 AM

	Unknown Object (File)
	Sat, Nov 2, 6:37 AM

	Unknown Object (File)
	Sat, Nov 2, 6:36 AM

	Unknown Object (File)
	Sat, Nov 2, 6:35 AM

Subscribers

Details

Reviewers

tomek
ashoat

Commits

rCOMMd64587314533: [web, native] Introduce and use `ThreadIsChannel` function

Summary

Introduce helper function as a follow-up of D3191, that simplifies logic for conditionally displaying Subchannels menu item.

Depends on D3191

Test Plan

Tested web and mobile app. Subchannels menu seems to work in the same way as before.

Diff Detail

Repository

Branch

jacek/subchannel-logic

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Feb 22 2022, 4:49 AM

Herald added subscribers: • karol, atul, • adrian, ashoat. · View Herald TranscriptFeb 22 2022, 4:50 AM

Harbormaster completed remote builds in B6951: Diff 9805.Feb 22 2022, 4:54 AM

• jacek requested review of this revision.Feb 22 2022, 4:54 AM

• jacek added a parent revision: D3191: [web] Introduce `Subchannels` thread menu actions.Feb 22 2022, 4:56 AM

• jacek edited the summary of this revision. (Show Details)

• jacek mentioned this in D3191: [web] Introduce `Subchannels` thread menu actions.Feb 22 2022, 4:59 AM

tomek requested changes to this revision.Feb 22 2022, 5:30 AM

tomek added inline comments.

lib/shared/thread-utils.js
146–147	We should use `threadIsChannel` here

This revision now requires changes to proceed.Feb 22 2022, 5:30 AM

Used the function following Tomek's suggestion

tomek accepted this revision.Feb 23 2022, 3:15 AM

tomek added inline comments.

lib/shared/thread-utils.js
144 ↗	(On Diff #9830)	Both `threadInChatList` and `threadIsChannel` return `boolean` so double negation is not necessary

This revision is now accepted and ready to land.Feb 23 2022, 3:15 AM

Herald added a reviewer: ashoat. · View Herald TranscriptFeb 23 2022, 3:15 AM

Herald added a subscriber: • benschac. · View Herald Transcript

This revision now requires review to proceed.Feb 23 2022, 3:15 AM

Harbormaster completed remote builds in B6966: Diff 9830.Feb 23 2022, 3:15 AM

I think there are several more places where this could be used... for instance, here. To find those places it might be useful to run git grep '== threadTypes.SIDEBAR'. That said, it's probably outside the scope of this diff.

This revision is now accepted and ready to land.Feb 23 2022, 11:23 AM

Removed redundant !!

Harbormaster completed remote builds in B7092: Diff 9992.Mar 1 2022, 3:37 AM

Closed by commit rCOMMd64587314533: [web, native] Introduce and use `ThreadIsChannel` function (authored by • jacek). · Explain WhyMar 2 2022, 2:15 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMMd64587314533: [web, native] Introduce and use `ThreadIsChannel` function.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

5 lines

native/

chat/

settings/

thread-settings.react.js

6 lines

web/

chat/

thread-menu.react.js

6 lines

Diff 9805

lib/shared/thread-utils.js

Loading...

native/chat/settings/thread-settings.react.js

Loading...

web/chat/thread-menu.react.js

Loading...