Page MenuHomePhabricator
Differential D3269

[CommCoreModule] Simplify `matchesInboundSession` return logic
ClosedPublic
Actions

Authored by atul on Feb 23 2022, 9:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 11:35 AM
Unknown Object (File)
Tue, Oct 22, 1:20 AM
Unknown Object (File)
Tue, Oct 22, 1:20 AM
Unknown Object (File)
Tue, Oct 22, 1:16 AM
Unknown Object (File)
Tue, Oct 22, 12:20 AM
Unknown Object (File)
Sep 20 2024, 1:47 AM
Unknown Object (File)
Sep 20 2024, 1:47 AM
Unknown Object (File)
Sep 14 2024, 4:50 PM
View All Files
Subscribers
• adrian
ashoat
• benschac

Details

Reviewers
• karol
varun
tomek
• jim
ashoat
Commits
rCOMM9dda4dd52097: [CommCoreModule] Simplify `matchesInboundSession` return logic
Summary

Minor thing I noticed when working in CryptoModule.cpp

Test Plan

Close reading.. logic should be identical

Diff Detail

Repository
rCOMM Comm
Branch
february23 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 23 2022, 9:46 AM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptFeb 23 2022, 9:46 AM
atul published this revision for review.Feb 23 2022, 9:51 AM
Harbormaster completed remote builds in B6977: Diff 9841.Feb 23 2022, 9:51 AM
tomek accepted this revision.Feb 23 2022, 10:25 AM
tomek added inline comments.
native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp
180–185

I was wondering if we can just return the result of this function, but it looks https://matrix-client.dpldocs.info/matrix.olm.olm_matches_inbound_session_from.html like value > 1 mean error.

Returns 1 if the session matches. Returns 0 if the session * does not match. Returns olm_error() on failure.

This revision is now accepted and ready to land.Feb 23 2022, 10:25 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 23 2022, 10:25 AM
Herald added a subscriber: • benschac. · View Herald Transcript
This revision now requires review to proceed.Feb 23 2022, 10:25 AM
ashoat accepted this revision.Feb 23 2022, 11:44 AM
ashoat added inline comments.
native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp
180–185

Thanks for sharing your research, @palys-swm – I had the same thought

This revision is now accepted and ready to land.Feb 23 2022, 11:44 AM
Closed by commit rCOMM9dda4dd52097: [CommCoreModule] Simplify `matchesInboundSession` return logic (authored by atul). · Explain WhyFeb 23 2022, 12:16 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9dda4dd52097: [CommCoreModule] Simplify `matchesInboundSession` return logic.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
CryptoTools/
15 lines

Diff 9841

View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

Loading...