[native] Remove .gitignore for BasePackageList.java
ClosedPublic
Actions

Authored by ashoat on Feb 24 2022, 6:32 AM.

Tags

None

Referenced Files

	F3249410: D3287.id9901.diff
	Fri, Nov 15, 2:28 PM

	F3249064: D3287.diff
	Fri, Nov 15, 12:14 PM

	Unknown Object (File)
	Sat, Nov 9, 6:45 PM

	Unknown Object (File)
	Sat, Nov 9, 3:18 PM

	Unknown Object (File)
	Sat, Nov 9, 3:17 PM

	Unknown Object (File)
	Sat, Nov 9, 2:55 PM

	Unknown Object (File)
	Sat, Oct 19, 12:32 PM

	Unknown Object (File)
	Oct 7 2024, 1:25 PM

Subscribers

Details

Reviewers

marcin
tomek

Commits

rCOMMfff147fd192f: [native] Remove .gitignore for BasePackageList.java

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/remove_basepackagelist.java

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 24 2022, 6:32 AM

Herald added subscribers: • karol, atul, • adrian. · View Herald TranscriptFeb 24 2022, 6:32 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 24 2022, 6:36 AM

Harbormaster failed remote builds in B7018: Diff 9897!

CI failure is unrelated and should be resolved by D3286

With expo modules this file is no longer generated, and having it present in local repository will cause android build to fail, therefore it is logical to remove it from .gitignore.

This revision is now accepted and ready to land.Feb 24 2022, 7:34 AM

Herald added a subscriber: • benschac. · View Herald TranscriptFeb 24 2022, 7:34 AM

This revision was landed with ongoing or failed builds.Feb 24 2022, 7:41 AM

Closed by commit rCOMMfff147fd192f: [native] Remove .gitignore for BasePackageList.java (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfff147fd192f: [native] Remove .gitignore for BasePackageList.java.

Revision Contents
Changeset List

Path

Size

native/

.gitignore

3 lines

Diff 9897

View Options

[native] Remove .gitignore for BasePackageList.javaClosedPublicActions