Page MenuHomePhabricator
Differential D3286

Add ClientGetReadReactor.cpp to project.pbxproj again
ClosedPublic
Actions

Authored by marcin on Feb 24 2022, 6:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 9:29 PM
Unknown Object (File)
Sat, Nov 9, 10:50 PM
Unknown Object (File)
Sat, Nov 9, 9:02 PM
Unknown Object (File)
Sat, Nov 9, 8:38 PM
Unknown Object (File)
Sat, Nov 9, 6:44 PM
Unknown Object (File)
Sat, Nov 9, 3:18 PM
Unknown Object (File)
Sat, Nov 9, 3:17 PM
Unknown Object (File)
Sat, Nov 9, 2:55 PM
View All Files
Subscribers
• adrian
ashoat
• benschac
• karol
Tokens
"Party Time" token, awarded by atul.

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMM93dced444bd3: Add ClientGetReadReactor.cpp to project.pbxproj again
Summary

When rebasing expo migration code to master I mistakenly deleted ClientGetReadReactor.cpp from project.pbxproj file when resolving confilcts. This urgent diff bring it back and solves iOS build failure on CI"

Test Plan

Sucessfully build app

Diff Detail

Repository
rCOMM Comm
Branch
marcin/expo-migration-urgent-fix
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Feb 24 2022, 6:04 AM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptFeb 24 2022, 6:04 AM
Harbormaster completed remote builds in B7017: Diff 9896.Feb 24 2022, 6:08 AM
marcin requested review of this revision.Feb 24 2022, 6:09 AM
tomek requested changes to this revision.Feb 24 2022, 6:29 AM
tomek added inline comments.
native/ios/Comm.xcodeproj/project.pbxproj
340 ↗(On Diff #9896)

Instead of removing this and SocketStatus.h, you should add them to PBXFileReference section from which they were removed

This revision now requires changes to proceed.Feb 24 2022, 6:29 AM
ashoat mentioned this in D3287: [native] Remove .gitignore for BasePackageList.java.Feb 24 2022, 6:45 AM
marcin updated this revision to Diff 9898.Feb 24 2022, 6:50 AM

Add SocketStatus.h and Metadata.h as the shuld not have been deleted.

Harbormaster completed remote builds in B7019: Diff 9898.Feb 24 2022, 6:54 AM
marcin updated this revision to Diff 9900.Feb 24 2022, 7:03 AM

Manually retrieve file references.

Harbormaster completed remote builds in B7020: Diff 9900.Feb 24 2022, 7:08 AM
tomek accepted this revision.Feb 24 2022, 7:17 AM
This revision is now accepted and ready to land.Feb 24 2022, 7:17 AM
Herald added a reviewer: ashoat. · View Herald TranscriptFeb 24 2022, 7:17 AM
Herald added a subscriber: • benschac. · View Herald Transcript
This revision now requires review to proceed.Feb 24 2022, 7:17 AM
ashoat accepted this revision.Feb 24 2022, 7:41 AM
This revision is now accepted and ready to land.Feb 24 2022, 7:41 AM
marcin updated this revision to Diff 9902.Feb 24 2022, 7:48 AM

Rebase - retriggering CI to be safe and sound.

Harbormaster completed remote builds in B7021: Diff 9902.Feb 24 2022, 7:52 AM
atul awarded a token.Feb 24 2022, 7:53 AM
Closed by commit rCOMM93dced444bd3: Add ClientGetReadReactor.cpp to project.pbxproj again (authored by marcin). · Explain WhyFeb 24 2022, 7:56 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM93dced444bd3: Add ClientGetReadReactor.cpp to project.pbxproj again.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
5 lines

Diff 9902

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...