Page MenuHomePhabricator
Feed Advanced Search

Aug 3 2023

patryk updated the diff for D8648: [native] Use new Alert wrapper.

Rebase and replace Alert in role-utils.react.js

Aug 3 2023, 12:55 PM
patryk closed D8590: [native] Warn the user when deleting a chat that has contained chats.
Aug 3 2023, 12:03 PM
patryk committed rCOMMa071dedf22ea: [native] Warn the user when deleting a chat that has contained chats (authored by patryk).
[native] Warn the user when deleting a chat that has contained chats
Aug 3 2023, 12:03 PM
patryk closed D8586: [native] Use currently selected theme for alerts..
Aug 3 2023, 12:02 PM
patryk committed rCOMMf79fafb48068: [native] Use currently selected theme for alerts. (authored by patryk).
[native] Use currently selected theme for alerts.
Aug 3 2023, 12:02 PM

Aug 2 2023

patryk closed D8530: [web] Warn the user when deleting a chat that has contained chats.
Aug 2 2023, 11:21 PM
patryk committed rCOMM6421b301872e: [web] Warn the user when deleting a chat that has contained chats (authored by patryk).
[web] Warn the user when deleting a chat that has contained chats
Aug 2 2023, 11:21 PM
patryk closed D8526: [lib] Add containedThreadInfos selector.
Aug 2 2023, 3:02 PM
patryk committed rCOMM28cbe2cf3e82: [lib] Add containedThreadInfos selector (authored by patryk).
[lib] Add containedThreadInfos selector
Aug 2 2023, 3:02 PM
patryk updated the diff for D8526: [lib] Add containedThreadInfos selector.

Rebase

Aug 2 2023, 1:37 PM
patryk closed D8525: [web] Fit video tag to wrapper.
Aug 2 2023, 12:07 PM
patryk committed rCOMM00ce9bf15a04: [web] Fit video tag to wrapper (authored by patryk).
[web] Fit video tag to wrapper
Aug 2 2023, 12:07 PM
patryk updated the diff for D8525: [web] Fit video tag to wrapper.

Rebase

Aug 2 2023, 12:03 PM
patryk updated the diff for D8590: [native] Warn the user when deleting a chat that has contained chats.

Use getThreadsToDeleteText function from lib.

Aug 2 2023, 3:48 AM
patryk retitled D8526: [lib] Add containedThreadInfos selector from [web] Add containedThreadInfos selector to [lib] Add containedThreadInfos selector.
Aug 2 2023, 3:44 AM
patryk updated the diff for D8530: [web] Warn the user when deleting a chat that has contained chats.

Move threadsToDeleteText to lib.

Aug 2 2023, 3:10 AM

Aug 1 2023

patryk added a comment to D8518: [web] Inherit min-height property for media elements.

Now attachments should be visible, sorry!

Aug 1 2023, 7:11 AM
patryk attached a referenced file: F669678: after_removing_mins.png.
Aug 1 2023, 7:10 AM
patryk attached a referenced file: F666981: stacked-images.png.
Aug 1 2023, 7:10 AM
patryk attached a referenced file: F666550: expl1.png.
Aug 1 2023, 7:10 AM
patryk accepted D8686: [lib] Replace BaseAppState<*> with default type param.
Aug 1 2023, 2:27 AM
patryk added a comment to D8518: [web] Inherit min-height property for media elements.

Regarding the previous comment, to fix zoomed-in small images problem, we could set min-width: inherit or min-height: inherit only when image height or width > 50px (current value for min-width/height):

// multimedia.react.js
// Remember to remove min-height: inherit from media.css!!
// ...
const elementStyle = React.useMemo(() => {
  if (!dimensions) {
    return undefined;
  }
  const { width, height } = dimensions;
  // Resize the image to fit in max width while preserving aspect ratio
  const calculatedWidth =
    Math.min(MAX_THUMBNAIL_HEIGHT, height) * (width / height);
  return {
    background: placeholderImage
      ? `center / cover url(${placeholderImage})`
      : undefined,
    width: `${calculatedWidth}px`, // (*)
    aspectRatio: `${width} / ${height}`,
    minWidth: height < 50 ? undefined : 'inherit', // <- change here
    minHeight: width < 50 ? undefined : 'inherit', // <- change here
  };
}, [dimensions, placeholderImage]);
// ...
Aug 1 2023, 2:18 AM
patryk updated the summary of D8526: [lib] Add containedThreadInfos selector.
Aug 1 2023, 12:59 AM
patryk updated the diff for D8526: [lib] Add containedThreadInfos selector.

Rebase and remove *.

Aug 1 2023, 12:58 AM

Jul 31 2023

patryk updated the diff for D8590: [native] Warn the user when deleting a chat that has contained chats.

Rework code, use new Alert wrapper.

Jul 31 2023, 3:33 AM
patryk added inline comments to D8590: [native] Warn the user when deleting a chat that has contained chats.
Jul 31 2023, 3:32 AM
patryk updated the summary of D8590: [native] Warn the user when deleting a chat that has contained chats.
Jul 31 2023, 3:32 AM
patryk planned changes to D8518: [web] Inherit min-height property for media elements.
Jul 31 2023, 3:22 AM
patryk updated the diff for D8530: [web] Warn the user when deleting a chat that has contained chats.

Use mixed type rather than void.

Jul 31 2023, 1:17 AM
patryk updated the diff for D8526: [lib] Add containedThreadInfos selector.

Unpack containingThreadID property.

Jul 31 2023, 1:10 AM
patryk attached a referenced file: F666110: square.png.
Jul 31 2023, 1:09 AM
patryk added a comment to D8518: [web] Inherit min-height property for media elements.

Recently I've tested this for images smaller than current min-width and min-height (all equal to 50px) and actually they are being "zoomed-in". In addition when we upload an small squared image (e.g. 30px x 30px), min-width is not maintained and we obtain something like this (image is an upload multimedia icon):

square.png (93×268 px, 5 KB)

When we set min-width: inherit; the problem is solved but the image is still enlarged. I will post another comment soon when I find a workaround for this issue.

Jul 31 2023, 1:08 AM
patryk added inline comments to D8526: [lib] Add containedThreadInfos selector.
Jul 31 2023, 12:49 AM

Jul 28 2023

patryk updated the diff for D8530: [web] Warn the user when deleting a chat that has contained chats.

Introduce a new function that calls return "community" if threadTypeIsCommunityRoot, and
threadNoun otherwise and use it in threadsToDeleteText variable.

Jul 28 2023, 9:04 AM
patryk updated the diff for D8530: [web] Warn the user when deleting a chat that has contained chats.

Fix confirmation modal text.

Jul 28 2023, 6:51 AM
patryk published D8648: [native] Use new Alert wrapper for review.
Jul 28 2023, 4:16 AM
patryk updated the diff for D8586: [native] Use currently selected theme for alerts..

Make type read-only.

Jul 28 2023, 12:56 AM

Jul 27 2023

patryk published D8647: [blob-service] Test HTTP Ranges for review.
Jul 27 2023, 1:19 PM
patryk published D8643: [blob-service] Clean up uploaded blob data if any test fails for review.
Jul 27 2023, 1:19 PM

Jul 25 2023

patryk accepted D8613: [docs] Update Terraform path in Nix docs.
Jul 25 2023, 3:42 AM
patryk updated the diff for D8586: [native] Use currently selected theme for alerts..

Refactor code.

Jul 25 2023, 1:40 AM
patryk added a comment to D8586: [native] Use currently selected theme for alerts..

How about creating a custom hook

Creating a custom hook is not a viable option. Consider dev-menu.js as an example. There are instances where we use Alert outside of a React component.

Jul 25 2023, 1:40 AM

Jul 21 2023

patryk added a comment to D8590: [native] Warn the user when deleting a chat that has contained chats.

Subtask to ENG-4423: ENG-4442

Jul 21 2023, 8:17 AM
patryk added a comment to D8530: [web] Warn the user when deleting a chat that has contained chats.

Subtask to ENG-4423: ENG-4441

Jul 21 2023, 8:13 AM
patryk updated the diff for D8530: [web] Warn the user when deleting a chat that has contained chats.

Change 'chat' to 'community' in modal text.

Jul 21 2023, 7:52 AM
patryk published D8590: [native] Warn the user when deleting a chat that has contained chats for review.
Jul 21 2023, 7:50 AM
patryk updated the diff for D8586: [native] Use currently selected theme for alerts..

Fix logic.

Jul 21 2023, 4:15 AM
patryk accepted D8454: [blob-service] Implement download logic with new db.
Jul 21 2023, 3:21 AM
patryk requested changes to D8454: [blob-service] Implement download logic with new db.

LGTM, just fix this nit.

Jul 21 2023, 3:06 AM
patryk attached a referenced file: F647819: REC-1.mp4.
Jul 21 2023, 2:37 AM
patryk added a comment to D8525: [web] Fit video tag to wrapper.

It doesn't (note: we don't support uploading videos on web right now, that's why there is only an image in chat input bar):

Note to video: I tested this on chat with encrypted and unencrypted multimedia.

Jul 21 2023, 2:36 AM

Jul 20 2023

patryk updated the diff for D8530: [web] Warn the user when deleting a chat that has contained chats.

Fix variable name.

Jul 20 2023, 7:15 AM
patryk added inline comments to D8586: [native] Use currently selected theme for alerts..
Jul 20 2023, 7:06 AM
patryk published D8586: [native] Use currently selected theme for alerts. for review.
Jul 20 2023, 6:38 AM

Jul 19 2023

patryk added a comment to D8530: [web] Warn the user when deleting a chat that has contained chats.

Note: I talked with Ted about this warning text.

Jul 19 2023, 4:33 AM
patryk closed D8483: [web] Fix stretched images bug.
Jul 19 2023, 1:24 AM
patryk committed rCOMMf447ed220729: [web] Fix stretched images bug (authored by patryk).
[web] Fix stretched images bug
Jul 19 2023, 1:24 AM
patryk published D8530: [web] Warn the user when deleting a chat that has contained chats for review.
Jul 19 2023, 1:05 AM
patryk published D8526: [lib] Add containedThreadInfos selector for review.
Jul 19 2023, 1:05 AM
patryk added a comment to D8483: [web] Fix stretched images bug.

Sorry, forgot to add comment here that I've created task for that: ENG-4405

Jul 19 2023, 1:02 AM

Jul 18 2023

patryk closed D8528: [web] Fix channel deletion problem.
Jul 18 2023, 11:58 PM
patryk committed rCOMMfaf8dceb7061: [web] Fix channel deletion problem (authored by patryk).
[web] Fix channel deletion problem
Jul 18 2023, 11:58 PM
patryk requested review of D8528: [web] Fix channel deletion problem.
Jul 18 2023, 6:24 AM
patryk updated the test plan for D8525: [web] Fit video tag to wrapper.
Jul 18 2023, 2:02 AM
patryk published D8525: [web] Fit video tag to wrapper for review.
Jul 18 2023, 1:59 AM

Jul 17 2023

patryk requested changes to D8454: [blob-service] Implement download logic with new db.
Jul 17 2023, 11:48 PM
patryk attached a referenced file: F641519: 0a8b8540155c4f95.png.
Jul 17 2023, 7:06 AM
patryk attached a referenced file: F641518: exp2.png.
Jul 17 2023, 7:06 AM
patryk attached a referenced file: F641516: 3b3f04b9-ceee-41e0-97f8-b5a4ce429387.png.
Jul 17 2023, 7:06 AM
patryk attached a referenced file: F641514: exp1.png.
Jul 17 2023, 7:06 AM
patryk updated the test plan for D8518: [web] Inherit min-height property for media elements.
Jul 17 2023, 7:06 AM
patryk closed D8498: [web] Fix closing MultimediaModal on ESC press bug.
Jul 17 2023, 6:12 AM
patryk committed rCOMM8ba42dce166a: [web] Fix closing MultimediaModal on ESC press bug (authored by patryk).
[web] Fix closing MultimediaModal on ESC press bug
Jul 17 2023, 6:12 AM
patryk added inline comments to D8498: [web] Fix closing MultimediaModal on ESC press bug.
Jul 17 2023, 5:51 AM
patryk updated the summary of D8518: [web] Inherit min-height property for media elements.
Jul 17 2023, 3:34 AM
patryk requested review of D8518: [web] Inherit min-height property for media elements.
Jul 17 2023, 3:21 AM
patryk updated the diff for D8483: [web] Fix stretched images bug.

Remove blanks

Jul 17 2023, 1:27 AM
patryk updated the diff for D8483: [web] Fix stretched images bug.

Removed border-radius and added comment in media.css, added new type for CSS styles

Jul 17 2023, 1:09 AM

Jul 14 2023

patryk published D8498: [web] Fix closing MultimediaModal on ESC press bug for review.
Jul 14 2023, 3:31 AM
patryk attached a referenced file: F635313: expl.png.
Jul 14 2023, 1:35 AM
patryk attached a referenced file: F635354: expl2.png.
Jul 14 2023, 1:35 AM
patryk attached a referenced file: F635367: expl3.png.
Jul 14 2023, 1:34 AM
patryk attached a referenced file: F635380: expl4.png.
Jul 14 2023, 1:34 AM
patryk attached a referenced file: F635381: expl7.png.
Jul 14 2023, 1:34 AM
patryk added inline comments to D8483: [web] Fix stretched images bug.
Jul 14 2023, 1:33 AM

Jul 13 2023

patryk added inline comments to D8483: [web] Fix stretched images bug.
Jul 13 2023, 8:32 AM
patryk added inline comments to D8483: [web] Fix stretched images bug.
Jul 13 2023, 8:29 AM
patryk attached a referenced file: F634434: not-css2.png.
Jul 13 2023, 6:01 AM
patryk attached a referenced file: F634466: issuelong.png.
Jul 13 2023, 6:01 AM
patryk attached a referenced file: F634467: iii2.png.
Jul 13 2023, 6:01 AM
patryk added inline comments to D8483: [web] Fix stretched images bug.
Jul 13 2023, 6:01 AM
ashoat renamed patryk from pklatka to patryk.
Jul 13 2023, 5:47 AM
patryk attached a referenced file: F633852: screen3.png.
Jul 13 2023, 1:38 AM
patryk attached a referenced file: F633853: screen4.png.
Jul 13 2023, 1:38 AM
patryk attached a referenced file: F633855: screen2.png.
Jul 13 2023, 1:37 AM
patryk attached a referenced file: F633854: screen1.png.
Jul 13 2023, 1:37 AM
patryk updated the summary of D8483: [web] Fix stretched images bug.
Jul 13 2023, 1:37 AM
patryk added inline comments to D8483: [web] Fix stretched images bug.
Jul 13 2023, 1:22 AM
patryk retitled D8483: [web] Fix stretched images bug from [web] Temporary fix for streched images bug to [web] Fix stretched images bug.
Jul 13 2023, 1:19 AM
patryk updated the diff for D8483: [web] Fix stretched images bug.

Fix thumbhash wrong dimensions and hide border when image tag doesn't have src attribute.

Jul 13 2023, 1:17 AM