Rebase and replace Alert in role-utils.react.js
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 3 2023
Aug 2 2023
Rebase
Use getThreadsToDeleteText function from lib.
Move threadsToDeleteText to lib.
Aug 1 2023
Now attachments should be visible, sorry!
Regarding the previous comment, to fix zoomed-in small images problem, we could set min-width: inherit or min-height: inherit only when image height or width > 50px (current value for min-width/height):
// multimedia.react.js // Remember to remove min-height: inherit from media.css!! // ... const elementStyle = React.useMemo(() => { if (!dimensions) { return undefined; } const { width, height } = dimensions; // Resize the image to fit in max width while preserving aspect ratio const calculatedWidth = Math.min(MAX_THUMBNAIL_HEIGHT, height) * (width / height); return { background: placeholderImage ? `center / cover url(${placeholderImage})` : undefined, width: `${calculatedWidth}px`, // (*) aspectRatio: `${width} / ${height}`, minWidth: height < 50 ? undefined : 'inherit', // <- change here minHeight: width < 50 ? undefined : 'inherit', // <- change here }; }, [dimensions, placeholderImage]); // ...
Rebase and remove *.
Jul 31 2023
Rework code, use new Alert wrapper.
Use mixed type rather than void.
Unpack containingThreadID property.
Recently I've tested this for images smaller than current min-width and min-height (all equal to 50px) and actually they are being "zoomed-in". In addition when we upload an small squared image (e.g. 30px x 30px), min-width is not maintained and we obtain something like this (image is an upload multimedia icon):
When we set min-width: inherit; the problem is solved but the image is still enlarged. I will post another comment soon when I find a workaround for this issue.
Jul 28 2023
Introduce a new function that calls return "community" if threadTypeIsCommunityRoot, and
threadNoun otherwise and use it in threadsToDeleteText variable.
Fix confirmation modal text.
Make type read-only.
Jul 27 2023
Jul 25 2023
Refactor code.
How about creating a custom hook
Creating a custom hook is not a viable option. Consider dev-menu.js as an example. There are instances where we use Alert outside of a React component.
Jul 21 2023
Change 'chat' to 'community' in modal text.
Fix logic.
LGTM, just fix this nit.
It doesn't (note: we don't support uploading videos on web right now, that's why there is only an image in chat input bar):
Note to video: I tested this on chat with encrypted and unencrypted multimedia.
Jul 20 2023
Fix variable name.
Jul 19 2023
Note: I talked with Ted about this warning text.
Sorry, forgot to add comment here that I've created task for that: ENG-4405
Jul 18 2023
Jul 17 2023
Remove blanks
Removed border-radius and added comment in media.css, added new type for CSS styles
Jul 14 2023
Jul 13 2023
Fix thumbhash wrong dimensions and hide border when image tag doesn't have src attribute.