Paths

Table of Contentst

-
lib/
-
selectors/
-
calendar-filter-selectors.js
-
chat-selectors.js
-
loading-selectors.js
-
local-id-selectors.js
-
nav-selectors.js
-
relationship-selectors.js
-
thread-selectors.js
-
user-selectors.js
-
types/
-
redux-types.js

[lib] Replace BaseAppState<*> with default type param
ClosedPublic
Actions

Authored by ashoat on Jul 31 2023, 11:34 AM.

Details

Reviewers

inka
michal
• patryk

Commits

rCOMMc451a8155e79: [lib] Replace BaseAppState<*> with default type param

Summary

* is basically any in modern versions of Flow. This diff removes most of the uses of * in our codebase.

This came up in D8526 and D8644.

Depends on D8685

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 31 2023, 11:34 AM

Herald added a subscriber: tomek. · View Herald TranscriptJul 31 2023, 11:34 AM

ashoat mentioned this in D8526: [lib] Add containedThreadInfos selector.Jul 31 2023, 11:39 AM

ashoat mentioned this in D8644: [lib, web, natvie] Add sessionID field to keyserverStore.Jul 31 2023, 11:50 AM

Harbormaster completed remote builds in B21392: Diff 29304.Jul 31 2023, 1:29 PM

ashoat requested review of this revision.Jul 31 2023, 1:29 PM

• patryk added a child revision: D8526: [lib] Add containedThreadInfos selector.Aug 1 2023, 12:59 AM

• patryk accepted this revision.Aug 1 2023, 2:27 AM

This revision is now accepted and ready to land.Aug 1 2023, 2:27 AM

Closed by commit rCOMMc451a8155e79: [lib] Replace BaseAppState<*> with default type param (authored by ashoat). · Explain WhyAug 1 2023, 6:27 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc451a8155e79: [lib] Replace BaseAppState<*> with default type param.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

calendar-filter-selectors.js

16 lines

chat-selectors.js

19 lines

loading-selectors.js

10 lines

local-id-selectors.js

2 lines

nav-selectors.js

8 lines

relationship-selectors.js

4 lines

thread-selectors.js

84 lines

user-selectors.js

28 lines

types/

redux-types.js

8 lines

Diff 29428

View Options

lib/selectors/calendar-filter-selectors.js

View Options

lib/selectors/chat-selectors.js

View Options

lib/selectors/loading-selectors.js

View Options

lib/selectors/local-id-selectors.js

View Options

lib/selectors/nav-selectors.js

View Options

lib/selectors/relationship-selectors.js

View Options

lib/selectors/thread-selectors.js

View Options

lib/selectors/user-selectors.js

View Options

[lib] Replace BaseAppState<*> with default type paramClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29428

lib/selectors/calendar-filter-selectors.js

lib/selectors/chat-selectors.js

lib/selectors/loading-selectors.js

lib/selectors/local-id-selectors.js

lib/selectors/nav-selectors.js

lib/selectors/relationship-selectors.js

lib/selectors/thread-selectors.js

lib/selectors/user-selectors.js

lib/types/redux-types.js

[lib] Replace BaseAppState<*> with default type param
ClosedPublic
Actions

Revision Contents
Changeset List