Page MenuHomePhabricator

[lib][native][web] Make Flow types for Redux state read-only
ClosedPublic

Authored by ashoat on Jul 31 2023, 11:33 AM.
Tags
None
Referenced Files
F2173545: D8685.id29427.diff
Tue, Jul 2, 10:24 PM
F2173541: D8685.id29302.diff
Tue, Jul 2, 10:23 PM
F2173539: D8685.diff
Tue, Jul 2, 10:23 PM
Unknown Object (File)
Tue, Jul 2, 12:01 AM
Unknown Object (File)
Jun 2 2024, 10:56 PM
Unknown Object (File)
Jun 2 2024, 10:55 PM
Unknown Object (File)
Jun 2 2024, 10:55 PM
Unknown Object (File)
May 29 2024, 4:08 AM
Subscribers

Details

Summary

This probably should've been done a long time ago. Best practice is to modernize a Flow type whenever you touch it, but evidently people were too intimidated to try and modernize BaseAppState and its various related types.

I went ahead and did this. It looks like it went well, with no new Flow errors.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable