Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Today

bartek closed D13993: [terraform] Deploy reports-v0.1.3 to staging and prod.

Thu, Nov 21, 9:16 AM

bartek committed rCOMMbae86cd4e6cc: [terraform] Deploy reports-v0.1.3 to staging and prod (authored by bartek).

[terraform] Deploy reports-v0.1.3 to staging and prod

Thu, Nov 21, 9:16 AM

bartek published D13957: [keyserver] Add function to clear identity metadata for review.

Thu, Nov 21, 9:13 AM

bartek published D13956: [lib] Log out on failed Tunnelbroker auth for review.

Thu, Nov 21, 9:12 AM

bartek published D13955: [lib] Add hook to log out on invalid CSAT for review.

I have two concerns about this diff:

Inline comment
When this hook is called, the device is immediately logged out without notice. This might be a bad user experience, so I thought about displaying an alert/modal saying sth like "This device has been externally logged out. Please log in again". On the other hand, when this device was logged out by the primary device, the user is expecting all devices to log out, so maybe the UX is not that bad.

Thu, Nov 21, 9:08 AM

bartek updated the diff for D13993: [terraform] Deploy reports-v0.1.3 to staging and prod.

Rebase

Thu, Nov 21, 7:57 AM

bartek published D13993: [terraform] Deploy reports-v0.1.3 to staging and prod for review.

Thu, Nov 21, 7:40 AM

bartek published D13958: [lib] Extract function to download blob for review.

Thu, Nov 21, 5:15 AM

bartek published D13960: [lib] Extract function to remove holder for review.

Thu, Nov 21, 4:28 AM

bartek published D13959: [lib] Extract function to assign holder for review.

Thu, Nov 21, 4:28 AM