@ashoat addressed the comments & modified all reducers in https://phab.comm.dev/D5851

updated flow typing

spacing, readonly

still planning changes tho

removed unnecessary function call

need flow fix me help

added public key to message prior to signing

working on adding siweTypes everywhere else still

updated comment

In D5603#168852, @ashoat wrote:

the only difference between sim and physical device is on sim, you scan the QR, and physical device will deep link you to rainbow and back to comm between every interaction (connecting wallet, signing message). i've tested it on the physical device, and it successfully deep links back and forth, so we can move forward with testing treating them the same

This sentence reads cleanly to me but I'm still a bit confused. Who handles the simulator differently? Where does the QR code appear?

Can you share a video of the QR code experience?

on sim there's no wallet to open a deep link with

In D5603#167857, @ashoat wrote:

This diff is way too large and should've been broken up. You're still in a PR mindset. I wish we had time to do it right but I know we'll miss our goals if I don't relax expectations

updated comment to be more descriptive

addressed comments

reverted changes applied to wrong diff

addressed comments

removed duplicate argument

added lowercase matching for ethereum addresses

factored out login queries

factored out login queries, fixed flow issues

modified url-utils to allow signing to go through

added siwe case to data being loaded

added SIWE login to user reducer

updated types & keyserver endpoint

@ashoat once this lands, i'll ping you to deploy landing

updated migration to be idempotent

In D5566#165379, @ashoat wrote:

I see 0x as a purely visual treatment, so I would prefer to have that handled by the UI.

It's also a good idea to check if creating an empty db also works correctly.

@derek can you amend your Test Plan to cover that please?

In D5566#165047, @ashoat wrote:

Overall looks good to me. Assume you've carefully tested that 42 chars is the right number?

updated migration number

separated second query into separate migration

i definitely need to brush up on my migration understanding - in the process of running those tests. will update diff & rerequest shortly

fixed syntax

updated column type

ran the app on my phone, played around with it.
the navigation action to a threaded chat took a while for the screen to animate after the press
ran it again in release mode and it was snappy.
let er rip

save some buildkites for a sunny day

🫡

added properties to db setup as well

@ashoat got it, i forgot that we're implicitly planning many new dbs to be created, as opposed to running migrations on a live sql instance.

updated function name to reflect dev only

addressed ashoat's comments

ran it, can confirm my following build did not require me to add the signing team to my pods

final resting place of sideEffects: true

camelcase babey