Page MenuHomePhabricator
Differential D5851

[lib] SIWE: added types & modified reducers
AbandonedPublicDraft
Actions

Authored by ashoat on Dec 9 2022, 2:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 4:47 AM
Unknown Object (File)
Sat, Mar 15, 11:03 PM
Unknown Object (File)
Sat, Mar 15, 11:03 PM
Unknown Object (File)
Sat, Mar 15, 11:03 PM
Unknown Object (File)
Sat, Mar 15, 11:03 PM
Unknown Object (File)
Sat, Mar 15, 11:03 PM
Unknown Object (File)
Sat, Mar 15, 11:03 PM
Unknown Object (File)
Sat, Mar 15, 11:02 PM
View All Files
Subscribers
• abosh
ashoat
atul
ginsu
rohan
tomek
varun

Details

Reviewers
ginsu
tomek
• derek
atul
Summary

refactored reducers to account for siweActionTypes, depends on D5634

Test Plan

coming soon

Diff Detail

Repository
rCOMM Comm
Branch
derek/login-types
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• derek created this revision.Dec 9 2022, 2:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:30 PM
Harbormaster failed remote builds in B14080: Diff 19276!
• derek updated this revision to Diff 19278.Dec 9 2022, 2:31 PM

rebased

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:32 PM
Harbormaster failed remote builds in B14081: Diff 19278!
• derek updated this revision to Diff 19279.Dec 9 2022, 2:40 PM

rebased

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:40 PM
Harbormaster failed remote builds in B14082: Diff 19279!
• derek updated this revision to Diff 19280.Dec 9 2022, 2:41 PM

rebased onto stack

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:41 PM
Harbormaster failed remote builds in B14083: Diff 19280!
• derek added inline comments.Dec 9 2022, 2:42 PM
lib/actions/user-actions.js
98 ↗(On Diff #19280)

no matter how i rebase this, i can't seem to get this endpoint to exist in the prior diff

• derek updated this revision to Diff 19281.Dec 9 2022, 2:44 PM

rebased to master

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:44 PM
Harbormaster failed remote builds in B14084: Diff 19281!
• derek updated this revision to Diff 19282.Dec 9 2022, 2:58 PM

rebased to include dependency on D5634

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:58 PM
Harbormaster failed remote builds in B14085: Diff 19282!
• derek edited the summary of this revision. (Show Details)Dec 9 2022, 2:58 PM
• derek added a parent revision: D5634: [keyserver] add public key/social proof to the cookie record.
• derek mentioned this in D5603: [keyserver/types] SIWE endpoint: types & native server call.Dec 9 2022, 3:01 PM
• derek updated this revision to Diff 19283.Dec 9 2022, 3:29 PM

removed duplicate

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 3:29 PM
Harbormaster failed remote builds in B14086: Diff 19283!
atul commandeered this revision.Dec 22 2022, 12:07 AM
atul edited reviewers, added: • derek; removed: atul.
ashoat added a comment.Dec 25 2022, 8:19 AM

I assume we're abandoning this one as well given @atul's comment. We can always come back to it later if we change our mind

ashoat commandeered this revision.Dec 25 2022, 8:19 AM
ashoat abandoned this revision.
ashoat added a reviewer: atul.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
2 lines
lib/
actions/
6 lines
reducers/
10 lines
6 lines
15 lines
7 lines
6 lines
25 lines
14 lines
8 lines
types/
7 lines
1 line
utils/
30 lines

Diff 19283

View Options

keyserver/src/creators/account-creator.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesfunction getUploadURL(id: string, secret: string): string {
if (isDev) { if (isDev) {
const ipV4 = ip.v4.sync() || 'localhost'; const ipV4 = ip.v4.sync() || 'localhost';
const port = parseInt(process.env.PORT, 10) || 3000; const port = parseInt(process.env.PORT, 10) || 3000;
return `http://${ipV4}:${port}${uploadPath}`; return `http://${ipV4}:${port}${uploadPath}`;
} }
return `${baseDomain}${uploadPath}`; return `${baseDomain}${uploadPath}`;
} }
function makeUploadURI(holder: ?string, id: string, secret: string): string { function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) { if (blobHash) {
return makeBlobServiceURI(holder); return makeBlobServiceURI(blobHash);
} }
return getUploadURL(id, secret); return getUploadURL(id, secret);
} }
function imagesFromRow(row: Object): Image | EncryptedImage { function imagesFromRow(row: Object): Image | EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra); const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra; const { width, height, blobHash, thumbHash } = uploadExtra;
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines
View Options

lib/actions/user-actions.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesfunction getUploadURL(id: string, secret: string): string {
if (isDev) { if (isDev) {
const ipV4 = ip.v4.sync() || 'localhost'; const ipV4 = ip.v4.sync() || 'localhost';
const port = parseInt(process.env.PORT, 10) || 3000; const port = parseInt(process.env.PORT, 10) || 3000;
return `http://${ipV4}:${port}${uploadPath}`; return `http://${ipV4}:${port}${uploadPath}`;
} }
return `${baseDomain}${uploadPath}`; return `${baseDomain}${uploadPath}`;
} }
function makeUploadURI(holder: ?string, id: string, secret: string): string { function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) { if (blobHash) {
return makeBlobServiceURI(holder); return makeBlobServiceURI(blobHash);
} }
return getUploadURL(id, secret); return getUploadURL(id, secret);
} }
function imagesFromRow(row: Object): Image | EncryptedImage { function imagesFromRow(row: Object): Image | EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra); const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra; const { width, height, blobHash, thumbHash } = uploadExtra;
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines
View Options

lib/reducers/calendar-filters-reducer.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesfunction getUploadURL(id: string, secret: string): string {
if (isDev) { if (isDev) {
const ipV4 = ip.v4.sync() || 'localhost'; const ipV4 = ip.v4.sync() || 'localhost';
const port = parseInt(process.env.PORT, 10) || 3000; const port = parseInt(process.env.PORT, 10) || 3000;
return `http://${ipV4}:${port}${uploadPath}`; return `http://${ipV4}:${port}${uploadPath}`;
} }
return `${baseDomain}${uploadPath}`; return `${baseDomain}${uploadPath}`;
} }
function makeUploadURI(holder: ?string, id: string, secret: string): string { function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) { if (blobHash) {
return makeBlobServiceURI(holder); return makeBlobServiceURI(blobHash);
} }
return getUploadURL(id, secret); return getUploadURL(id, secret);
} }
function imagesFromRow(row: Object): Image | EncryptedImage { function imagesFromRow(row: Object): Image | EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra); const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra; const { width, height, blobHash, thumbHash } = uploadExtra;
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines
View Options

lib/reducers/connection-reducer.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesfunction getUploadURL(id: string, secret: string): string {
if (isDev) { if (isDev) {
const ipV4 = ip.v4.sync() || 'localhost'; const ipV4 = ip.v4.sync() || 'localhost';
const port = parseInt(process.env.PORT, 10) || 3000; const port = parseInt(process.env.PORT, 10) || 3000;
return `http://${ipV4}:${port}${uploadPath}`; return `http://${ipV4}:${port}${uploadPath}`;
} }
return `${baseDomain}${uploadPath}`; return `${baseDomain}${uploadPath}`;
} }
function makeUploadURI(holder: ?string, id: string, secret: string): string { function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) { if (blobHash) {
return makeBlobServiceURI(holder); return makeBlobServiceURI(blobHash);
} }
return getUploadURL(id, secret); return getUploadURL(id, secret);
} }
function imagesFromRow(row: Object): Image | EncryptedImage { function imagesFromRow(row: Object): Image | EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra); const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra; const { width, height, blobHash, thumbHash } = uploadExtra;
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines
View Options

lib/reducers/data-loaded-reducer.js

Loading...
View Options

lib/reducers/entry-reducer.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/reducers/message-reducer.js

Loading...
View Options

lib/reducers/thread-reducer.js

Loading...
View Options

lib/reducers/updates-reducer.js

Loading...
View Options

lib/types/account-types.js

Loading...
View Options

lib/types/entry-types.js

Loading...
View Options

lib/utils/action-utils.js

Loading...