Page MenuHomePhabricator
Differential D5519

Revert "[sql/keyserver] removed/edited columns affected by SIWE"
AbandonedPublic
Actions

Authored by • derek on Nov 2 2022, 10:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 10, 1:59 PM
Unknown Object (File)
Sun, May 5, 7:39 PM
Unknown Object (File)
Wed, May 1, 3:40 PM
Unknown Object (File)
Wed, May 1, 3:10 PM
Unknown Object (File)
Apr 15 2024, 3:55 PM
Unknown Object (File)
Apr 15 2024, 1:56 AM
Unknown Object (File)
Apr 14 2024, 1:08 PM
Unknown Object (File)
Apr 14 2024, 1:07 PM
View All 59 Files
Subscribers
• abosh
ashoat
atul
ginsu
tomek

Details

Reviewers
ashoat
ginsu
Summary

This reverts commit ce520b5a419c0a38e4b2209153c61503a71680b2 due to a fatal error

Test Plan

n/a

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• derek created this revision.Nov 2 2022, 10:50 AM
Herald added subscribers: • abosh, atul, tomek. · View Herald TranscriptNov 2 2022, 10:50 AM
• derek edited the summary of this revision. (Show Details)Nov 2 2022, 10:54 AM
ashoat added a comment.Nov 2 2022, 10:55 AM

Probably would be better just to fix your code by adding multipleStatements?

keyserver/src/database/migration-config.js
51

Reverting migrations is really sketchy business, since now you have to think about both the scenario where the user is on version 5 and still has public_key, versus the scenario where the user is on version 6 and doesn't have it anymore.

This is probably only safe if:

  1. You make sure never to use ID 6 again, and you quickly introduce a new migration at ID 7 so nobody uses 6
  2. You modify the queries to be idempotent once you reintroduce them as migration 7
Harbormaster completed remote builds in B13133: Diff 18027.Nov 2 2022, 11:04 AM
• derek requested review of this revision.Nov 2 2022, 11:04 AM
• derek abandoned this revision.Nov 2 2022, 11:19 AM
• derek marked an inline comment as done.
• derek added inline comments.
keyserver/src/database/migration-config.js
51

got it - i panicked & immediately opened a reversion. closing in favor of https://phab.comm.dev/D5521

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
13 lines
14 lines

Diff 18027

View Options

keyserver/src/database/migration-config.js

Loading...
View Options

keyserver/src/database/setup-db.js

Loading...