Paths

Table of Contentst

Differential D5519

Revert "[sql/keyserver] removed/edited columns affected by SIWE"
AbandonedPublic
Actions

Authored by • derek on Nov 2 2022, 10:50 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 24, 5:55 PM

	Unknown Object (File)
	Thu, Oct 17, 9:01 AM

	Unknown Object (File)
	Thu, Oct 17, 9:01 AM

	Unknown Object (File)
	Thu, Oct 17, 8:54 AM

	Unknown Object (File)
	Sep 17 2024, 12:01 PM

	Unknown Object (File)
	Sep 17 2024, 2:39 AM

	Unknown Object (File)
	Sep 17 2024, 2:38 AM

	Unknown Object (File)
	Sep 17 2024, 2:30 AM

View All 94 Files

Subscribers

Details

Reviewers

ashoat
ginsu

Summary

This reverts commit ce520b5a419c0a38e4b2209153c61503a71680b2 due to a fatal error

Test Plan

n/a

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• derek created this revision.Nov 2 2022, 10:50 AM

Herald added subscribers: • abosh, atul, tomek. · View Herald TranscriptNov 2 2022, 10:50 AM

• derek edited the summary of this revision. (Show Details)Nov 2 2022, 10:54 AM

Probably would be better just to fix your code by adding multipleStatements?

keyserver/src/database/migration-config.js
51	Reverting migrations is really sketchy business, since now you have to think about both the scenario where the user is on version 5 and still has `public_key`, versus the scenario where the user is on version 6 and doesn't have it anymore. This is probably only safe if: You make sure never to use ID 6 again, and you quickly introduce a new migration at ID 7 so nobody uses 6 You modify the queries to be idempotent once you reintroduce them as migration 7

Harbormaster completed remote builds in B13133: Diff 18027.Nov 2 2022, 11:04 AM

• derek requested review of this revision.Nov 2 2022, 11:04 AM

• derek abandoned this revision.Nov 2 2022, 11:19 AM

• derek marked an inline comment as done.

• derek added inline comments.

keyserver/src/database/migration-config.js
51	got it - i panicked & immediately opened a reversion. closing in favor of https://phab.comm.dev/D5521

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

migration-config.js

13 lines

14 lines

Diff 18027

keyserver/src/database/migration-config.js

Loading...

keyserver/src/database/setup-db.js

Loading...