Page MenuHomePhabricator
Feed Advanced Search

Dec 9 2022

derek requested review of D5603: [keyserver/types] SIWE endpoint: types & native server call.

@ashoat addressed the comments & modified all reducers in https://phab.comm.dev/D5851

Dec 9 2022, 3:01 PM

Nov 22 2022

derek updated the diff for D5634: [keyserver] add public key/social proof to the cookie record.

updated flow typing

Nov 22 2022, 11:04 AM

Nov 21 2022

derek added inline comments to D5634: [keyserver] add public key/social proof to the cookie record.
Nov 21 2022, 7:15 AM
derek updated the diff for D5634: [keyserver] add public key/social proof to the cookie record.

spacing, readonly

Nov 21 2022, 7:15 AM

Nov 19 2022

derek planned changes to D5634: [keyserver] add public key/social proof to the cookie record.

still planning changes tho

Nov 19 2022, 12:56 PM
derek updated the diff for D5634: [keyserver] add public key/social proof to the cookie record.

removed unnecessary function call

Nov 19 2022, 12:56 PM
derek planned changes to D5634: [keyserver] add public key/social proof to the cookie record.

need flow fix me help

Nov 19 2022, 12:55 PM
derek updated the diff for D5634: [keyserver] add public key/social proof to the cookie record.

added public key to message prior to signing

Nov 19 2022, 12:53 PM
derek planned changes to D5603: [keyserver/types] SIWE endpoint: types & native server call.

working on adding siweTypes everywhere else still

Nov 19 2022, 12:13 PM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

updated comment

Nov 19 2022, 12:12 PM
derek added inline comments to D5603: [keyserver/types] SIWE endpoint: types & native server call.
Nov 19 2022, 11:58 AM
derek added a comment to D5603: [keyserver/types] SIWE endpoint: types & native server call.

the only difference between sim and physical device is on sim, you scan the QR, and physical device will deep link you to rainbow and back to comm between every interaction (connecting wallet, signing message). i've tested it on the physical device, and it successfully deep links back and forth, so we can move forward with testing treating them the same

This sentence reads cleanly to me but I'm still a bit confused. Who handles the simulator differently? Where does the QR code appear?

Can you share a video of the QR code experience?

on sim there's no wallet to open a deep link with

Simulator Screen Recording - iPhone 14 Pro - 2022-11-19 at 14.55.16.gif (640×295 px, 712 KB)

Nov 19 2022, 11:55 AM

Nov 18 2022

derek updated the test plan for D5603: [keyserver/types] SIWE endpoint: types & native server call.
Nov 18 2022, 10:02 AM
derek added a comment to D5603: [keyserver/types] SIWE endpoint: types & native server call.

This diff is way too large and should've been broken up. You're still in a PR mindset. I wish we had time to do it right but I know we'll miss our goals if I don't relax expectations

Nov 18 2022, 9:49 AM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

updated comment to be more descriptive

Nov 18 2022, 9:45 AM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

addressed comments

Nov 18 2022, 9:44 AM
derek updated the diff for D5634: [keyserver] add public key/social proof to the cookie record.

reverted changes applied to wrong diff

Nov 18 2022, 9:40 AM
derek updated the diff for D5634: [keyserver] add public key/social proof to the cookie record.

addressed comments

Nov 18 2022, 9:36 AM
derek planned changes to D5603: [keyserver/types] SIWE endpoint: types & native server call.
Nov 18 2022, 9:36 AM
derek updated the diff for D5634: [keyserver] add public key/social proof to the cookie record.

removed duplicate argument

Nov 18 2022, 8:18 AM
derek added inline comments to D5634: [keyserver] add public key/social proof to the cookie record.
Nov 18 2022, 8:17 AM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

added lowercase matching for ethereum addresses

Nov 18 2022, 8:11 AM

Nov 17 2022

derek updated the summary of D5634: [keyserver] add public key/social proof to the cookie record.
Nov 17 2022, 9:21 AM

Nov 16 2022

derek requested review of D5634: [keyserver] add public key/social proof to the cookie record.
Nov 16 2022, 9:57 AM
derek added inline comments to D5603: [keyserver/types] SIWE endpoint: types & native server call.
Nov 16 2022, 9:47 AM
derek updated the test plan for D5603: [keyserver/types] SIWE endpoint: types & native server call.
Nov 16 2022, 9:35 AM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

factored out login queries

Nov 16 2022, 9:34 AM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

factored out login queries, fixed flow issues

Nov 16 2022, 9:32 AM

Nov 15 2022

derek updated the summary of D5603: [keyserver/types] SIWE endpoint: types & native server call.
Nov 15 2022, 12:19 PM
derek updated the summary of D5603: [keyserver/types] SIWE endpoint: types & native server call.
Nov 15 2022, 12:18 PM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

modified url-utils to allow signing to go through

Nov 15 2022, 12:04 PM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

added siwe case to data being loaded

Nov 15 2022, 11:54 AM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

added SIWE login to user reducer

Nov 15 2022, 11:51 AM
derek updated the diff for D5603: [keyserver/types] SIWE endpoint: types & native server call.

updated types & keyserver endpoint

Nov 15 2022, 11:39 AM

Nov 10 2022

derek closed D5598: [landing] added argument to SIWE webview message.
Nov 10 2022, 1:43 PM
derek committed rCOMMacde9ed66e4e: [landing] added argument to SIWE webview message (authored by derek).
[landing] added argument to SIWE webview message
Nov 10 2022, 1:43 PM
derek added a comment to D5598: [landing] added argument to SIWE webview message.

@ashoat once this lands, i'll ping you to deploy landing

Nov 10 2022, 12:22 PM
derek added a reviewer for D5598: [landing] added argument to SIWE webview message: ashoat.
Nov 10 2022, 12:22 PM
derek requested review of D5603: [keyserver/types] SIWE endpoint: types & native server call.
Nov 10 2022, 12:00 PM
derek requested review of D5598: [landing] added argument to SIWE webview message.
Nov 10 2022, 9:43 AM

Nov 9 2022

derek closed D5566: [sql] added ethereum_address to users table.
Nov 9 2022, 8:20 AM
derek committed rCOMM71c4b0f8b0b4: [sql] added ethereum_address to users table (authored by derek).
[sql] added ethereum_address to users table
Nov 9 2022, 8:20 AM
derek requested review of D5566: [sql] added ethereum_address to users table.
Nov 9 2022, 7:45 AM
derek updated the diff for D5566: [sql] added ethereum_address to users table.

updated migration to be idempotent

Nov 9 2022, 7:44 AM
derek updated the test plan for D5566: [sql] added ethereum_address to users table.
Nov 9 2022, 7:44 AM
derek added a comment to D5566: [sql] added ethereum_address to users table.

I see 0x as a purely visual treatment, so I would prefer to have that handled by the UI.

It's also a good idea to check if creating an empty db also works correctly.

@derek can you amend your Test Plan to cover that please?

Nov 9 2022, 7:39 AM

Nov 8 2022

derek added a comment to D5566: [sql] added ethereum_address to users table.

Overall looks good to me. Assume you've carefully tested that 42 chars is the right number?

Nov 8 2022, 1:24 PM
derek requested review of D5566: [sql] added ethereum_address to users table.
Nov 8 2022, 12:15 PM

Nov 3 2022

derek added inline comments to D5521: [sql/keyserver] added multipleStatements to fix fatal error.
Nov 3 2022, 9:16 AM

Nov 2 2022

derek updated the diff for D5521: [sql/keyserver] added multipleStatements to fix fatal error.

updated migration number

Nov 2 2022, 1:00 PM
derek updated the diff for D5521: [sql/keyserver] added multipleStatements to fix fatal error.

separated second query into separate migration

Nov 2 2022, 12:59 PM
derek planned changes to D5521: [sql/keyserver] added multipleStatements to fix fatal error.

i definitely need to brush up on my migration understanding - in the process of running those tests. will update diff & rerequest shortly

Nov 2 2022, 12:14 PM
derek updated the test plan for D5521: [sql/keyserver] added multipleStatements to fix fatal error.
Nov 2 2022, 12:12 PM
derek requested review of D5521: [sql/keyserver] added multipleStatements to fix fatal error.
Nov 2 2022, 11:32 AM
derek abandoned D5519: Revert "[sql/keyserver] removed/edited columns affected by SIWE".
Nov 2 2022, 11:19 AM
derek requested review of D5519: Revert "[sql/keyserver] removed/edited columns affected by SIWE".
Nov 2 2022, 11:04 AM
derek added a reverting change for D5494: [sql/keyserver] removed/edited columns affected by SIWE: D5519: Revert "[sql/keyserver] removed/edited columns affected by SIWE".
Nov 2 2022, 10:50 AM
derek added a reverting change for rCOMMce520b5a419c: [sql/keyserver] removed/edited columns affected by SIWE: D5519: Revert "[sql/keyserver] removed/edited columns affected by SIWE".
Nov 2 2022, 10:50 AM
derek closed D5494: [sql/keyserver] removed/edited columns affected by SIWE.
Nov 2 2022, 8:34 AM
derek committed rCOMMce520b5a419c: [sql/keyserver] removed/edited columns affected by SIWE (authored by derek).
[sql/keyserver] removed/edited columns affected by SIWE
Nov 2 2022, 8:34 AM

Nov 1 2022

derek closed D5512: [keyserver] added siwe packages.
Nov 1 2022, 7:13 AM
derek committed rCOMMe4e42e88c56c: [keyserver] added siwe packages (authored by derek).
[keyserver] added siwe packages
Nov 1 2022, 7:13 AM

Oct 31 2022

derek requested review of D5512: [keyserver] added siwe packages.
Oct 31 2022, 1:33 PM

Oct 28 2022

derek added inline comments to D5494: [sql/keyserver] removed/edited columns affected by SIWE.
Oct 28 2022, 9:15 AM
derek updated the diff for D5494: [sql/keyserver] removed/edited columns affected by SIWE.

fixed syntax

Oct 28 2022, 9:13 AM

Oct 27 2022

derek requested review of D5494: [sql/keyserver] removed/edited columns affected by SIWE.
Oct 27 2022, 11:16 AM

Oct 21 2022

derek closed D5438: [keyserver/sql] add SIWE columns.
Oct 21 2022, 9:09 AM
derek committed rCOMM6df5a6495bc9: [keyserver/sql] add SIWE columns (authored by derek).
[keyserver/sql] add SIWE columns
Oct 21 2022, 9:09 AM
derek added inline comments to D5438: [keyserver/sql] add SIWE columns.
Oct 21 2022, 7:22 AM
derek updated the diff for D5438: [keyserver/sql] add SIWE columns.

updated column type

Oct 21 2022, 7:21 AM

Oct 20 2022

derek accepted D5427: [native] [34/34] ReactNav6: Update package versions.

ran the app on my phone, played around with it.
the navigation action to a threaded chat took a while for the screen to animate after the press
ran it again in release mode and it was snappy.
let er rip

Oct 20 2022, 12:09 PM
derek accepted D5445: [yarn] Add `yarn patch` command to `package.json`.

save some buildkites for a sunny day

Oct 20 2022, 11:49 AM
derek published D5445: [yarn] Add `yarn patch` command to `package.json` for review.

🫡

Oct 20 2022, 11:49 AM
derek updated the diff for D5438: [keyserver/sql] add SIWE columns.

added properties to db setup as well

Oct 20 2022, 10:11 AM
derek added a comment to D5438: [keyserver/sql] add SIWE columns.

@ashoat got it, i forgot that we're implicitly planning many new dbs to be created, as opposed to running migrations on a live sql instance.

Oct 20 2022, 10:09 AM
derek requested review of D5438: [keyserver/sql] add SIWE columns.
Oct 20 2022, 8:49 AM

Oct 17 2022

derek closed D5382: [native] derive SIWE url instead of hardcoding it.
Oct 17 2022, 10:47 AM
derek committed rCOMM0820e31451a5: [native] derive SIWE url instead of hardcoding it (authored by derek).
[native] derive SIWE url instead of hardcoding it
Oct 17 2022, 10:47 AM
derek updated the diff for D5382: [native] derive SIWE url instead of hardcoding it.

updated function name to reflect dev only

Oct 17 2022, 10:46 AM
derek updated the diff for D5382: [native] derive SIWE url instead of hardcoding it.

addressed ashoat's comments

Oct 17 2022, 10:18 AM
derek requested review of D5382: [native] derive SIWE url instead of hardcoding it.
Oct 17 2022, 9:31 AM

Oct 14 2022

derek closed D5293: added services secrets directory to gitignore.
Oct 14 2022, 12:29 PM
derek committed rCOMM4e3cddaa65ff: added services secrets directory to gitignore (authored by derek).
added services secrets directory to gitignore
Oct 14 2022, 12:29 PM

Oct 4 2022

derek updated the summary of D5293: added services secrets directory to gitignore.
Oct 4 2022, 8:12 AM
derek requested review of D5293: added services secrets directory to gitignore.
Oct 4 2022, 8:10 AM
derek closed D5287: [keyserver] added grpc packages to be able to talk to identity service.
Oct 4 2022, 7:56 AM
derek committed rCOMM5be9298782b6: [keyserver] added grpc packages to be able to talk to identity service (authored by derek).
[keyserver] added grpc packages to be able to talk to identity service
Oct 4 2022, 7:56 AM

Oct 3 2022

derek requested review of D5287: [keyserver] added grpc packages to be able to talk to identity service.
Oct 3 2022, 10:41 AM
derek accepted D5276: [native] Add Podfile hack to disable Signing Team requirement.

ran it, can confirm my following build did not require me to add the signing team to my pods

Oct 3 2022, 7:10 AM

Sep 26 2022

derek closed D5224: [landing] added sideEffects to solve node_module CSS (rainbowkit) not being added in production.
Sep 26 2022, 7:24 AM
derek committed rCOMM999e6100365e: [landing] added sideEffects to solve node_module CSS (rainbowkit) not being… (authored by derek).
[landing] added sideEffects to solve node_module CSS (rainbowkit) not being…
Sep 26 2022, 7:24 AM

Sep 23 2022

derek added inline comments to D5224: [landing] added sideEffects to solve node_module CSS (rainbowkit) not being added in production.
Sep 23 2022, 12:44 PM
derek updated the diff for D5224: [landing] added sideEffects to solve node_module CSS (rainbowkit) not being added in production.

final resting place of sideEffects: true

Sep 23 2022, 11:53 AM
derek requested review of D5224: [landing] added sideEffects to solve node_module CSS (rainbowkit) not being added in production.
Sep 23 2022, 11:47 AM

Sep 20 2022

derek closed D5161: [landing] updated which wagmi parameter is the actual address.
Sep 20 2022, 10:25 AM
derek committed rCOMMafc567e66d62: [landing] updated which wagmi parameter is the actual address (authored by derek).
[landing] updated which wagmi parameter is the actual address
Sep 20 2022, 10:25 AM

Sep 16 2022

derek closed D5023: [native] added webview to login with working SIWE (registration only).
Sep 16 2022, 8:35 AM
derek committed rCOMM9f2b86dcbcef: [native] added webview to login with working SIWE (registration only) (authored by derek).
[native] added webview to login with working SIWE (registration only)
Sep 16 2022, 8:35 AM
derek requested review of D5161: [landing] updated which wagmi parameter is the actual address.
Sep 16 2022, 8:34 AM
derek updated the diff for D5023: [native] added webview to login with working SIWE (registration only).

camelcase babey

Sep 16 2022, 8:33 AM