Page MenuHomePhabricator

added services secrets directory to gitignore
ClosedPublic

Authored by derek on Oct 4 2022, 7:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 1:51 AM
Unknown Object (File)
Wed, Nov 6, 11:49 PM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
Unknown Object (File)
Sat, Oct 19, 10:09 AM
Unknown Object (File)
Oct 5 2024, 9:38 PM
Unknown Object (File)
Sep 26 2024, 1:52 AM

Details

Summary

we need a key for the identity service to work in the context of cargo run server. ignoring it so we don't have to stash it or recreate it switching between branches

Test Plan

discuss with varun/ashoat if there are any red flags to this change

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Nice, love that you're running it (or trying to run it?) locally

Only partially related to this change, but we should avoid assuming configuration files will be co-located to the binary. Instead of defaulting to a relative directory (e.g. ./secrets/), we should really be defaulting to something like XDG_CONFIG_HOME which is usually only writable to a specific user. For linux systems which have adopted KDE, GNOME, or systemd, these values will be well-defined for users and services. https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html. The other benefit is that the file location will also not be dependent from where you run the application. (e.g. cargo run vs cargo build && cd target/debug && ./identity vs cargo install && identity)

related: https://linear.app/comm/issue/ENG-1961/allow-for-identity-to-be-configured-by-a-file-environment-variables-or

This revision is now accepted and ready to land.Oct 10 2022, 12:14 PM