added services secrets directory to gitignore
ClosedPublic
Actions

Authored by • derek on Oct 4 2022, 7:59 AM.

Details

Reviewers

varun

Commits

rCOMM4e3cddaa65ff: added services secrets directory to gitignore

Summary

we need a key for the identity service to work in the context of cargo run server. ignoring it so we don't have to stash it or recreate it switching between branches

Test Plan

discuss with varun/ashoat if there are any red flags to this change

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• derek created this revision.Oct 4 2022, 7:59 AM

Herald added a subscriber: • abosh. · View Herald TranscriptOct 4 2022, 7:59 AM

Harbormaster completed remote builds in B12597: Diff 17320.Oct 4 2022, 8:10 AM

• derek requested review of this revision.Oct 4 2022, 8:10 AM

• derek edited the summary of this revision. (Show Details)Oct 4 2022, 8:12 AM

Nice, love that you're running it (or trying to run it?) locally

Only partially related to this change, but we should avoid assuming configuration files will be co-located to the binary. Instead of defaulting to a relative directory (e.g. ./secrets/), we should really be defaulting to something like XDG_CONFIG_HOME which is usually only writable to a specific user. For linux systems which have adopted KDE, GNOME, or systemd, these values will be well-defined for users and services. https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html. The other benefit is that the file location will also not be dependent from where you run the application. (e.g. cargo run vs cargo build && cd target/debug && ./identity vs cargo install && identity)