User Details
- User Since
- Aug 17 2021, 1:57 AM (167 w, 1 d)
- Roles
- Disabled
Sep 5 2022
Sep 2 2022
address feedback
remove containsInlineSidebar prop
Sep 1 2022
fix css name
address feedback
rebase
used shared logic
address feedback - moved logic into common hook
rebase
address feedback
return null for robotext message
address feedback
address feedback
address feedback
rebase
add afterAll to set default window width and height in tests
add alignment parameter
remove tooltip align styles
rebase
rebase
rebase
Aug 29 2022
Used constants from constants file
Used JS constants in styles to support correct measuring size
Change return type to non-optional & add tests
Reabase & address feedback
changed JS styles to CSS classes
removed parameter from onMouseLeaveTooltip
remove redundant check in renderTooltip
Address suggestions after review
Aug 26 2022
For the majority of our contexts we split them into two files: one with context declaration and one with the provider (e.g. keyboard-state or sqlite-context). We don't have a naming convention for these, but probably tooltip-context and tooltip-context-provider would make a lot of sense.
We didn't use this convention for web app. In web app, both menu and modal context were defined together with the provider, so I followed the convention used there. I'm not sure if it's better to keep the context type separated from the provider implementation, but I can separate it if you like.