Page MenuHomePhabricator

jacek (Jacek Nitychoruk)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Aug 17 2021, 1:57 AM (167 w, 1 d)
Roles
Disabled

Recent Activity

Sep 5 2022

jacek closed D5039: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.
Sep 5 2022, 3:13 AM
jacek closed D5021: [web] Move `tooltip-utils` into `web/utils`.
Sep 5 2022, 3:13 AM
jacek committed rCOMMd89c8f499c0c: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle` (authored by jacek).
[web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`
Sep 5 2022, 3:13 AM
jacek closed D4924: [web] Redesign `InlineSidebar` with reactions support.
Sep 5 2022, 3:13 AM
jacek committed rCOMMf59b2df0c809: [web] Move `tooltip-utils` into `web/utils` (authored by jacek).
[web] Move `tooltip-utils` into `web/utils`
Sep 5 2022, 3:13 AM
jacek closed D4923: [web] Remove old tooltip components.
Sep 5 2022, 3:13 AM
jacek committed rCOMM9be4870f0bdc: [web] Redesign `InlineSidebar` with reactions support (authored by jacek).
[web] Redesign `InlineSidebar` with reactions support
Sep 5 2022, 3:13 AM
jacek closed D4922: [web] Remove timestamp tooltip from `ChatMessageList`.
Sep 5 2022, 3:13 AM
jacek committed rCOMMdbdac9d30be7: [web] Remove old tooltip components (authored by jacek).
[web] Remove old tooltip components
Sep 5 2022, 3:13 AM
jacek committed rCOMMc8b753e4f9b7: [web] Remove timestamp tooltip from `ChatMessageList` (authored by jacek).
[web] Remove timestamp tooltip from `ChatMessageList`
Sep 5 2022, 3:13 AM
jacek closed D4921: [web] Use new tooltip in robotext message.
Sep 5 2022, 3:13 AM
jacek committed rCOMM6f5610db9d1c: [web] Use new tooltip in robotext message (authored by jacek).
[web] Use new tooltip in robotext message
Sep 5 2022, 3:13 AM
jacek closed D4919: [web] Wrap app content with `TooltipProvider`.
Sep 5 2022, 3:13 AM
jacek closed D4920: [web] Use new tooltip in composed message.
Sep 5 2022, 3:13 AM
jacek closed D4918: [web] Introduce `useMessageTooltipActions` hooks.
Sep 5 2022, 3:13 AM
jacek committed rCOMMa7c1314455db: [web] Use new tooltip in composed message (authored by jacek).
[web] Use new tooltip in composed message
Sep 5 2022, 3:13 AM
jacek closed D4917: [web] Introduce `useMessageTooltipReplyAction` hook.
Sep 5 2022, 3:13 AM
jacek committed rCOMM44d4262ea03e: [web] Introduce `useMessageTooltipActions` hooks (authored by jacek).
[web] Introduce `useMessageTooltipActions` hooks
Sep 5 2022, 3:13 AM
jacek committed rCOMMc12778cdcedd: [web] Wrap app content with `TooltipProvider` (authored by jacek).
[web] Wrap app content with `TooltipProvider`
Sep 5 2022, 3:13 AM
jacek closed D4916: [web] Introduce `useMessageTooltipSidebarAction` hook.
Sep 5 2022, 3:13 AM
jacek committed rCOMMd1eb10a17867: [web] Introduce `useMessageTooltipReplyAction` hook (authored by jacek).
[web] Introduce `useMessageTooltipReplyAction` hook
Sep 5 2022, 3:13 AM
jacek closed D4915: [web] Introduce `getMessageActionTooltipStyle` util function.
Sep 5 2022, 3:13 AM
jacek committed rCOMM928a05031726: [web] Introduce `useMessageTooltipSidebarAction` hook (authored by jacek).
[web] Introduce `useMessageTooltipSidebarAction` hook
Sep 5 2022, 3:13 AM
jacek committed rCOMMbe81697106d2: [web] Introduce `getMessageActionTooltipStyle` util function (authored by jacek).
[web] Introduce `getMessageActionTooltipStyle` util function
Sep 5 2022, 3:13 AM
jacek closed D4913: [web] Modify `findTooltipPosition` to support new tooltip positioning logic.
Sep 5 2022, 3:13 AM
jacek closed D4914: [web] Introduce `calculateTooltipSize` util function.
Sep 5 2022, 3:13 AM
jacek committed rCOMMd74f93465e62: [web] Modify `findTooltipPosition` to support new tooltip positioning logic (authored by jacek).
[web] Modify `findTooltipPosition` to support new tooltip positioning logic
Sep 5 2022, 3:13 AM
jacek committed rCOMM7b34eea1a231: [web] Introduce `calculateTooltipSize` util function (authored by jacek).
[web] Introduce `calculateTooltipSize` util function
Sep 5 2022, 3:13 AM
jacek closed D4912: [web] Refactor `MessageTooltip` component.
Sep 5 2022, 3:13 AM
jacek closed D4911: [web] Introduce tooltip container with positioning in `TooltipContext`.
Sep 5 2022, 3:13 AM
jacek committed rCOMM36b1f6c71dcb: [web] Refactor `MessageTooltip` component (authored by jacek).
[web] Refactor `MessageTooltip` component
Sep 5 2022, 3:13 AM
jacek committed rCOMM411deb4acee0: [web] Introduce tooltip container with positioning in `TooltipContext` (authored by jacek).
[web] Introduce tooltip container with positioning in `TooltipContext`
Sep 5 2022, 3:13 AM
jacek closed D4910: [web] Introduce `onMouse` calbacks for tooltip component in `TooltipContext`.
Sep 5 2022, 3:13 AM
jacek closed D4909: [web] Introduce `clearTooltip` and `renderTooltip` functions in `TooltipContext`.
Sep 5 2022, 3:13 AM
jacek committed rCOMM952451feac8e: [web] Introduce `onMouse` calbacks for tooltip component in `TooltipContext` (authored by jacek).
[web] Introduce `onMouse` calbacks for tooltip component in `TooltipContext`
Sep 5 2022, 3:13 AM
jacek committed rCOMMcc69386826ae: [web] Introduce `clearTooltip` and `renderTooltip` functions in `TooltipContext` (authored by jacek).
[web] Introduce `clearTooltip` and `renderTooltip` functions in `TooltipContext`
Sep 5 2022, 3:13 AM
jacek closed D4908: [web] Introduce `TooltipContext`.
Sep 5 2022, 3:13 AM
jacek committed rCOMM843bcd8b4fa5: [web] Introduce `TooltipContext` (authored by jacek).
[web] Introduce `TooltipContext`
Sep 5 2022, 3:13 AM

Sep 2 2022

jacek retitled D5039: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle` from [web] Rename `x/yCoord` to `x/yAnchorPoint` in `TooltipPositionStyle` to [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.
Sep 2 2022, 7:48 AM
jacek requested review of D5039: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.
Sep 2 2022, 7:48 AM
jacek updated the diff for D5039: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.

address feedback

Sep 2 2022, 7:47 AM
jacek added inline comments to D5039: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.
Sep 2 2022, 6:46 AM
jacek requested review of D5039: [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`.
Sep 2 2022, 5:53 AM
jacek added inline comments to D4915: [web] Introduce `getMessageActionTooltipStyle` util function.
Sep 2 2022, 5:40 AM
jacek updated the diff for D4921: [web] Use new tooltip in robotext message.

remove containsInlineSidebar prop

Sep 2 2022, 5:35 AM
jacek added inline comments to D4921: [web] Use new tooltip in robotext message.
Sep 2 2022, 5:33 AM
jacek added inline comments to D4921: [web] Use new tooltip in robotext message.
Sep 2 2022, 5:30 AM

Sep 1 2022

jacek requested review of D5021: [web] Move `tooltip-utils` into `web/utils`.
Sep 1 2022, 7:36 AM
jacek updated the diff for D4912: [web] Refactor `MessageTooltip` component.

fix css name

Sep 1 2022, 7:27 AM
jacek added inline comments to D4924: [web] Redesign `InlineSidebar` with reactions support.
Sep 1 2022, 7:17 AM
jacek updated the diff for D4924: [web] Redesign `InlineSidebar` with reactions support.

address feedback

Sep 1 2022, 7:17 AM
jacek updated the diff for D4923: [web] Remove old tooltip components.

rebase

Sep 1 2022, 7:16 AM
jacek updated the diff for D4922: [web] Remove timestamp tooltip from `ChatMessageList`.

rebase

Sep 1 2022, 7:15 AM
jacek updated the diff for D4921: [web] Use new tooltip in robotext message.

used shared logic

Sep 1 2022, 7:14 AM
jacek updated the diff for D4920: [web] Use new tooltip in composed message.

address feedback - moved logic into common hook

Sep 1 2022, 7:12 AM
jacek updated the diff for D4919: [web] Wrap app content with `TooltipProvider`.

rebase

Sep 1 2022, 7:11 AM
jacek retitled D4918: [web] Introduce `useMessageTooltipActions` hooks from [web] Introduce `use...MessageTooltipActions` hooks to [web] Introduce `useMessageTooltipActions` hooks.
Sep 1 2022, 7:10 AM
jacek updated the diff for D4918: [web] Introduce `useMessageTooltipActions` hooks.

address feedback

Sep 1 2022, 7:10 AM
jacek updated the diff for D4917: [web] Introduce `useMessageTooltipReplyAction` hook.

return null for robotext message

Sep 1 2022, 7:08 AM
jacek updated the diff for D4916: [web] Introduce `useMessageTooltipSidebarAction` hook.

address feedback

Sep 1 2022, 7:07 AM
jacek updated the diff for D4915: [web] Introduce `getMessageActionTooltipStyle` util function.

address feedback

Sep 1 2022, 7:02 AM
jacek updated the diff for D4914: [web] Introduce `calculateTooltipSize` util function.

address feedback

Sep 1 2022, 6:59 AM
jacek updated the diff for D4914: [web] Introduce `calculateTooltipSize` util function.

rebase

Sep 1 2022, 6:58 AM
jacek updated the diff for D4913: [web] Modify `findTooltipPosition` to support new tooltip positioning logic.

add afterAll to set default window width and height in tests

Sep 1 2022, 6:57 AM
jacek updated the diff for D4912: [web] Refactor `MessageTooltip` component.

add alignment parameter

Sep 1 2022, 6:55 AM
jacek updated the diff for D4911: [web] Introduce tooltip container with positioning in `TooltipContext`.

remove tooltip align styles

Sep 1 2022, 6:54 AM
jacek updated the diff for D4910: [web] Introduce `onMouse` calbacks for tooltip component in `TooltipContext`.

rebase

Sep 1 2022, 6:53 AM
jacek updated the diff for D4909: [web] Introduce `clearTooltip` and `renderTooltip` functions in `TooltipContext`.

rebase

Sep 1 2022, 6:52 AM
jacek updated the diff for D4909: [web] Introduce `clearTooltip` and `renderTooltip` functions in `TooltipContext`.

rebase

Sep 1 2022, 6:50 AM
jacek updated the diff for D4908: [web] Introduce `TooltipContext`.

rebase

Sep 1 2022, 6:49 AM
jacek updated the diff for D4908: [web] Introduce `TooltipContext`.

rebase

Sep 1 2022, 6:43 AM
jacek added a comment to D4923: [web] Remove old tooltip components.
In D4923#143832, @tomek wrote:

Tested if all the actions work as before.

Have you tested if the set of actions is exactly the same as before?

Sep 1 2022, 6:21 AM
jacek updated the test plan for D4923: [web] Remove old tooltip components.
Sep 1 2022, 6:21 AM
jacek updated the test plan for D4923: [web] Remove old tooltip components.
Sep 1 2022, 6:21 AM
jacek added inline comments to D4920: [web] Use new tooltip in composed message.
Sep 1 2022, 4:43 AM
jacek added inline comments to D4916: [web] Introduce `useMessageTooltipSidebarAction` hook.
Sep 1 2022, 3:35 AM

Aug 29 2022

jacek updated the diff for D4914: [web] Introduce `calculateTooltipSize` util function.

Used constants from constants file

Aug 29 2022, 7:23 AM
jacek updated the diff for D4912: [web] Refactor `MessageTooltip` component.

Used JS constants in styles to support correct measuring size

Aug 29 2022, 7:20 AM
jacek added inline comments to D4918: [web] Introduce `useMessageTooltipActions` hooks.
Aug 29 2022, 7:09 AM
jacek updated the test plan for D4913: [web] Modify `findTooltipPosition` to support new tooltip positioning logic.
Aug 29 2022, 5:38 AM
jacek updated the diff for D4913: [web] Modify `findTooltipPosition` to support new tooltip positioning logic.

Change return type to non-optional & add tests

Aug 29 2022, 5:36 AM
jacek updated the diff for D4912: [web] Refactor `MessageTooltip` component.

Reabase & address feedback

Aug 29 2022, 5:34 AM
jacek updated the diff for D4911: [web] Introduce tooltip container with positioning in `TooltipContext`.

changed JS styles to CSS classes

Aug 29 2022, 5:32 AM
jacek updated the diff for D4910: [web] Introduce `onMouse` calbacks for tooltip component in `TooltipContext`.

removed parameter from onMouseLeaveTooltip

Aug 29 2022, 5:30 AM
jacek updated the diff for D4909: [web] Introduce `clearTooltip` and `renderTooltip` functions in `TooltipContext`.

remove redundant check in renderTooltip

Aug 29 2022, 5:28 AM
jacek updated the diff for D4908: [web] Introduce `TooltipContext`.

Address suggestions after review

Aug 29 2022, 5:26 AM
jacek added inline comments to D4914: [web] Introduce `calculateTooltipSize` util function.
Aug 29 2022, 5:25 AM
jacek attached a referenced file: F152053: Screenshot_Linear_2022-08-29_141646.png.
Aug 29 2022, 5:24 AM
jacek added inline comments to D4915: [web] Introduce `getMessageActionTooltipStyle` util function.
Aug 29 2022, 5:23 AM
jacek added inline comments to D4913: [web] Modify `findTooltipPosition` to support new tooltip positioning logic.
Aug 29 2022, 5:06 AM
jacek added inline comments to D4913: [web] Modify `findTooltipPosition` to support new tooltip positioning logic.
Aug 29 2022, 3:53 AM
jacek added inline comments to D4913: [web] Modify `findTooltipPosition` to support new tooltip positioning logic.
Aug 29 2022, 3:46 AM
jacek updated the summary of D4913: [web] Modify `findTooltipPosition` to support new tooltip positioning logic.
Aug 29 2022, 3:44 AM
jacek added inline comments to D4912: [web] Refactor `MessageTooltip` component.
Aug 29 2022, 3:32 AM
jacek added inline comments to D4911: [web] Introduce tooltip container with positioning in `TooltipContext`.
Aug 29 2022, 3:26 AM
jacek added inline comments to D4910: [web] Introduce `onMouse` calbacks for tooltip component in `TooltipContext`.
Aug 29 2022, 2:53 AM
jacek added inline comments to D4909: [web] Introduce `clearTooltip` and `renderTooltip` functions in `TooltipContext`.
Aug 29 2022, 2:40 AM

Aug 26 2022

jacek added a comment to D4908: [web] Introduce `TooltipContext`.

For the majority of our contexts we split them into two files: one with context declaration and one with the provider (e.g. keyboard-state or sqlite-context). We don't have a naming convention for these, but probably tooltip-context and tooltip-context-provider would make a lot of sense.

We didn't use this convention for web app. In web app, both menu and modal context were defined together with the provider, so I followed the convention used there. I'm not sure if it's better to keep the context type separated from the provider implementation, but I can separate it if you like.

Aug 26 2022, 6:36 AM

Aug 25 2022

jacek closed D4825: [native] Introduce `inlineSidebar` animation when opening message tooltip to avoid visual issues..
Aug 25 2022, 1:39 AM
jacek closed D4824: [native] Redesign `InlineSidebar` for reactions feature.
Aug 25 2022, 1:39 AM