HomePhabricator
Diffusion Comm 14a54ad05d59

[native] split the inline engagement pill into two

Description

[native] split the inline engagement pill into two

Summary:
As a first step to redesigning the InlineEngagement component we should split the sidebar and the reactions into two separate pills. For context, this is what the new inline engagement component is supposed to look like:

Screenshot 2023-07-13 at 5.47.56 PM.png (966×2 px, 290 KB)

This diff begins to break the chat height measurement, as such this diff and subsequent diffs won't be landed until the rest of the native inline engagement work w/ correct height measurement is completed

Linear Task: https://linear.app/comm/issue/ENG-3103/update-inlineengagement-for-native

Depends on D8496

Test Plan:
Please look at the screenshots below to see the changes

Before:

Screenshot 2023-07-13 at 5.30.56 PM.png (1×960 px, 741 KB)

Screenshot 2023-07-13 at 5.31.12 PM.png (1×1 px, 847 KB)

After:

Screenshot 2023-07-13 at 5.31.59 PM.png (1×1 px, 929 KB)

Screenshot 2023-07-13 at 5.31.49 PM.png (1×1 px, 847 KB)

Reviewers: atul, kamil

Reviewed By: kamil

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8497

Details

Provenance
ginsuAuthored on Jul 13 2023, 2:32 PM
Reviewer
kamil
Differential Revision
D8497: [native] split the inline engagement pill into two
Parents
rCOMM2d893db09936: [native] clean up InlineEngagement component
Branches
Unknown
Tags
Unknown