Details

Reviewers

atul
kamil

Commits

rCOMM14a54ad05d59: [native] split the inline engagement pill into two

Summary

As a first step to redesigning the InlineEngagement component we should split the sidebar and the reactions into two separate pills. For context, this is what the new inline engagement component is supposed to look like:

Screenshot 2023-07-13 at 5.47.56 PM.png (966×2 px, 290 KB)

This diff begins to break the chat height measurement, as such this diff and subsequent diffs won't be landed until the rest of the native inline engagement work w/ correct height measurement is completed

Linear Task: https://linear.app/comm/issue/ENG-3103/update-inlineengagement-for-native

Depends on D8496

Test Plan

Please look at the screenshots below to see the changes

Before:

Screenshot 2023-07-13 at 5.30.56 PM.png (1×960 px, 741 KB)

Screenshot 2023-07-13 at 5.31.12 PM.png (1×1 px, 847 KB)

After:

Screenshot 2023-07-13 at 5.31.59 PM.png (1×1 px, 929 KB)

Screenshot 2023-07-13 at 5.31.49 PM.png (1×1 px, 847 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 13 2023, 2:42 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 13 2023, 2:42 PM

ginsu edited the summary of this revision. (Show Details)Jul 13 2023, 2:49 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8496: [native] clean up InlineEngagement component.

ginsu edited the summary of this revision. (Show Details)

ginsu attached a referenced file: F634910: Screenshot 2023-07-13 at 5.31.49 PM.png. (Show Details)

ginsu attached a referenced file: F634938: Screenshot 2023-07-13 at 5.31.59 PM.png. (Show Details)

ginsu attached a referenced file: F634909: Screenshot 2023-07-13 at 5.31.12 PM.png. (Show Details)

ginsu attached a referenced file: F634908: Screenshot 2023-07-13 at 5.30.56 PM.png. (Show Details)

ginsu attached a referenced file: F634937: Screenshot 2023-07-13 at 5.47.56 PM.png. (Show Details)

cleanup unused style

forgot to hit save

Harbormaster completed remote builds in B20927: Diff 28681.Jul 13 2023, 2:59 PM

ginsu added inline comments.Jul 13 2023, 3:00 PM

native/chat/inline-engagement.react.js
149–166 ↗	(On Diff #28684)	Eventually we are going to get rid of this code in a subsequent diff, but just adding `sidebarItem` and `reactionList` for now so this diff isn't super big