[native] show which reactions the viewer has already selected in the inline engagement
ClosedPublic
Actions

Authored by ginsu on Jul 21 2023, 12:21 PM.

Details

Reviewers

atul
kamil

Commits

rCOMMb23bb9048b28: [native] show which reactions the viewer has already selected in the inline…

Summary

To improve the user experience of the inline engagement, we should show/indicate to the user which reactions they have already selected. We indicate this to the user by adding a border to the reaction pill.

Depends on D8578

Test Plan

Confirmed the width/height of the reaction pills are all the same regardless if it has been selected by the viewer or not:

Screenshot 2023-07-21 at 3.27.48 PM.png (1×1 px, 1 MB)

Screenshot 2023-07-21 at 3.27.42 PM.png (1×1 px, 1 MB)

Please watch the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 21 2023, 12:21 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2023, 12:21 PM

ginsu added inline comments.Jul 21 2023, 12:23 PM

native/chat/inline-engagement.react.js
300–301 ↗	(On Diff #28954)	We use 7 and 3 here because the border will add 1px so the total will match the original reaction pill height/width

ginsu edited the summary of this revision. (Show Details)Jul 21 2023, 12:24 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8578: [native] introduce functionality to send a reaction by pressing on the reaction pill..

ginsu attached a referenced file: F648674: Screen Recording 2023-07-21 at 3.24.11 PM.mov. (Show Details)

ginsu edited the test plan for this revision. (Show Details)Jul 21 2023, 12:28 PM

ginsu attached a referenced file: F648679: Screenshot 2023-07-21 at 3.27.42 PM.png. (Show Details)

ginsu attached a referenced file: F648678: Screenshot 2023-07-21 at 3.27.48 PM.png. (Show Details)

Harbormaster completed remote builds in B21132: Diff 28954.Jul 21 2023, 12:39 PM

ginsu requested review of this revision.Jul 21 2023, 12:39 PM

kamil accepted this revision.Jul 24 2023, 1:58 AM

This revision is now accepted and ready to land.Jul 24 2023, 1:58 AM

ginsu added a child revision: D8609: [lib/native/web] convert useInlineEngagementText to getInlineEngagmentSidebarText.Jul 24 2023, 4:22 PM

simplify

Harbormaster completed remote builds in B21349: Diff 29240.Jul 30 2023, 3:01 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 31 2023, 1:19 PM

Closed by commit rCOMMb23bb9048b28: [native] show which reactions the viewer has already selected in the inline… (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMb23bb9048b28: [native] show which reactions the viewer has already selected in the inline….

Harbormaster completed remote builds in B21396: Diff 29308.Jul 31 2023, 2:20 PM

Revision Contents
Changeset List

Path

Size

native/

chat/

inline-engagement.react.js

17 lines

Diff 29358

View Options

native/chat/inline-engagement.react.js

This file was added.

				FROM commapp/services-base:1.1

				RUN apt-get update && \
				apt-get install -y uuid-dev && \
				rm -rf /var/lib/apt/lists/*

				ARG COMM_TEST_SERVICES
				ARG COMM_SERVICES_DEV_MODE

				ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}
				ENV COMM_SERVICES_DEV_MODE=${COMM_SERVICES_DEV_MODE}

				WORKDIR /transferred

				COPY native/cpp/CommonCpp/grpc/protos/backup.proto native/cpp/CommonCpp/grpc/protos/blob.proto protos/
				COPY services/backup/docker/ scripts/
				COPY services/backup/ .

				RUN scripts/build_server.sh

				CMD if [ "$COMM_TEST_SERVICES" -eq 1 ]; then scripts/run_tests.sh; else scripts/run_server.sh; fi

[native] show which reactions the viewer has already selected in the inline engagementClosedPublicActions