Page MenuHomePhabricator
Differential D8576

[native] make reactions prop for InlineEngagement requried
ClosedPublic
Actions

Authored by ginsu on Jul 19 2023, 2:38 PM.
Tags
None
Referenced Files
F5933974: D8576.id28952.diff
Fri, Apr 18, 5:47 AM
Unknown Object (File)
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Wed, Mar 26, 4:52 PM
Unknown Object (File)
Wed, Mar 26, 4:51 PM
Unknown Object (File)
Mar 17 2025, 6:16 PM
Unknown Object (File)
Mar 17 2025, 6:16 PM
Unknown Object (File)
Mar 17 2025, 6:16 PM
Unknown Object (File)
Mar 17 2025, 6:16 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM104bf7c713c4: [native] make reactions prop for InlineEngagement requried
Summary

In the very next diff we will introduce sending a reaction by pressing on a pill. To prepare for this we need to make reactions prop required so we can use the sendReaction hook

Depends on D8575

Test Plan

flow and confirmed that the InlineEngagement still looks and works as expected for both composed messages and robotext messages

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 19 2023, 2:38 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 19 2023, 2:38 PM
ginsu added inline comments.Jul 19 2023, 2:52 PM
native/chat/inline-engagement.react.js
41–42 ↗(On Diff #28869)

I just moved this below sidebarInfo so the ordering matched the prop type above

ginsu edited the summary of this revision. (Show Details)Jul 19 2023, 2:53 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8575: [native] add spacing in between each reaction pill.
ginsu edited the summary of this revision. (Show Details)Jul 19 2023, 2:55 PM
ginsu added a child revision: D8578: [native] introduce functionality to send a reaction by pressing on the reaction pill..Jul 19 2023, 3:31 PM
Harbormaster completed remote builds in B21069: Diff 28869.Jul 19 2023, 3:35 PM
ginsu requested review of this revision.Jul 19 2023, 3:35 PM
kamil accepted this revision.Jul 21 2023, 2:55 AM
This revision is now accepted and ready to land.Jul 21 2023, 2:55 AM
ginsu updated this revision to Diff 28952.Jul 21 2023, 11:48 AM

rebase

Harbormaster completed remote builds in B21130: Diff 28952.Jul 21 2023, 12:05 PM
ginsu updated this revision to Diff 29306.Jul 31 2023, 11:37 AM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 31 2023, 1:19 PM
Closed by commit rCOMM104bf7c713c4: [native] make reactions prop for InlineEngagement requried (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM104bf7c713c4: [native] make reactions prop for InlineEngagement requried.
Harbormaster completed remote builds in B21394: Diff 29306.Jul 31 2023, 1:55 PM

Revision Contents
Changeset List

PathSize
native/
chat/
11 lines

Diff 29356

View Options

native/chat/inline-engagement.react.js

Show All 31 Lines
import { TextInput } from './modal-components.react.js'; import { TextInput } from './modal-components.react.js';
import { setNativeCredentials } from './native-credentials.js'; import { setNativeCredentials } from './native-credentials.js';
import { PanelButton, Panel } from './panel-components.react.js'; import { PanelButton, Panel } from './panel-components.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import { NavContext } from '../navigation/navigation-context.js'; import { NavContext } from '../navigation/navigation-context.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js'; import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js';
import type { KeyPressEvent } from '../types/react-native.js'; import type { KeyPressEvent } from '../types/react-native.js';
import { useInitialNotificationsEncryptedMessage } from '../utils/crypto-utils.js';
import { type StateContainer } from '../utils/state-container.js'; import { type StateContainer } from '../utils/state-container.js';
export type RegisterState = { export type RegisterState = {
+usernameInputText: string, +usernameInputText: string,
+passwordInputText: string, +passwordInputText: string,
+confirmPasswordInputText: string, +confirmPasswordInputText: string,
}; };
type BaseProps = { type BaseProps = {
+setActiveAlert: (activeAlert: boolean) => void, +setActiveAlert: (activeAlert: boolean) => void,
+opacityValue: Animated.Node, +opacityValue: Animated.Node,
+registerState: StateContainer<RegisterState>, +registerState: StateContainer<RegisterState>,
}; };
type Props = { type Props = {
...BaseProps, ...BaseProps,
+loadingStatus: LoadingStatus, +loadingStatus: LoadingStatus,
+logInExtraInfo: () => Promise<LogInExtraInfo>, +logInExtraInfo: () => Promise<LogInExtraInfo>,
+dispatchActionPromise: DispatchActionPromise, +dispatchActionPromise: DispatchActionPromise,
+register: (registerInfo: RegisterInfo) => Promise<RegisterResult>, +register: (registerInfo: RegisterInfo) => Promise<RegisterResult>,
+getInitialNotificationsEncryptedMessage: () => Promise<string>,
}; };
type State = { type State = {
+confirmPasswordFocused: boolean, +confirmPasswordFocused: boolean,
}; };
class RegisterPanel extends React.PureComponent<Props, State> { class RegisterPanel extends React.PureComponent<Props, State> {
state: State = { state: State = {
confirmPasswordFocused: false, confirmPasswordFocused: false,
}; };
▲ Show 20 Lines • Show All 218 Lines • ▼ Show 20 Lines ) {
'letter or a number, and may contain only letters, numbers, or the ' + 'letter or a number, and may contain only letters, numbers, or the ' +
'characters “-” and “_”', 'characters “-” and “_”',
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else { } else {
Keyboard.dismiss(); Keyboard.dismiss();
const extraInfo = await this.props.logInExtraInfo(); const extraInfo = await this.props.logInExtraInfo();
const initialNotificationsEncryptedMessage =
await this.props.getInitialNotificationsEncryptedMessage();
this.props.dispatchActionPromise( this.props.dispatchActionPromise(
registerActionTypes, registerActionTypes,
this.registerAction(extraInfo), this.registerAction({
...extraInfo,
initialNotificationsEncryptedMessage,
}),
undefined, undefined,
({ calendarQuery: extraInfo.calendarQuery }: LogInStartingPayload), ({ calendarQuery: extraInfo.calendarQuery }: LogInStartingPayload),
); );
} }
}; };
onPasswordAlertAcknowledged = () => { onPasswordAlertAcknowledged = () => {
this.props.setActiveAlert(false); this.props.setActiveAlert(false);
▲ Show 20 Lines • Show All 149 Lines • ▼ Show 20 Lines const logInExtraInfo = useSelector(state =>
nativeLogInExtraInfoSelector({ nativeLogInExtraInfoSelector({
redux: state, redux: state,
navContext, navContext,
}), }),
); );
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callRegister = useServerCall(register); const callRegister = useServerCall(register);
const getInitialNotificationsEncryptedMessage =
useInitialNotificationsEncryptedMessage();
return ( return (
<RegisterPanel <RegisterPanel
{...props} {...props}
loadingStatus={loadingStatus} loadingStatus={loadingStatus}
logInExtraInfo={logInExtraInfo} logInExtraInfo={logInExtraInfo}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
register={callRegister} register={callRegister}
getInitialNotificationsEncryptedMessage={
getInitialNotificationsEncryptedMessage
}
/> />
); );
}); });
export default ConnectedRegisterPanel; export default ConnectedRegisterPanel;