Page MenuHomePhabricator
Differential D8317

[lib] add reply/replies back to sidebar inline engagement
ClosedPublic
Actions

Authored by ginsu on Jun 26 2023, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 27, 6:59 AM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:07 PM
Unknown Object (File)
Sat, Mar 1, 12:26 PM
Unknown Object (File)
Feb 18 2025, 5:20 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM206d67e9da1c: [lib] add reply/replies back to sidebar inline engagement
Summary

Based off this comment in Linear, we want to add the word reply/replies in order to differentiate the thread replies from the reactions

Linear Task: https://linear.app/comm/issue/ENG-3103/update-inlineengagement-for-native

Test Plan

Please see the screenshots below:

Screenshot 2023-06-24 at 2.06.39 PM.png (1×1 px, 818 KB)

Screenshot 2023-06-24 at 2.05.37 PM.png (1×1 px, 817 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 26 2023, 3:25 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 26 2023, 3:25 PM
ginsu edited the summary of this revision. (Show Details)Jun 26 2023, 3:28 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F608235: Screenshot 2023-06-24 at 2.05.37 PM.png. (Show Details)
ginsu attached a referenced file: F608236: Screenshot 2023-06-24 at 2.06.39 PM.png. (Show Details)
Harbormaster completed remote builds in B20512: Diff 28124.Jun 26 2023, 3:43 PM
ginsu requested review of this revision.Jun 26 2023, 3:43 PM
kamil accepted this revision.Jun 27 2023, 1:17 AM
This revision is now accepted and ready to land.Jun 27 2023, 1:17 AM
ginsu added a child revision: D8496: [native] clean up InlineEngagement component.Jul 13 2023, 10:03 AM
ginsu retitled this revision from [native] add reply/replies back to sidebar inline engagement to [lib] add reply/replies back to sidebar inline engagement.Jul 26 2023, 10:56 AM
ginsu updated this revision to Diff 29299.Jul 31 2023, 11:29 AM

rebase before landing

Harbormaster completed remote builds in B21387: Diff 29299.Jul 31 2023, 12:23 PM
Closed by commit rCOMM206d67e9da1c: [lib] add reply/replies back to sidebar inline engagement (authored by ginsu). · Explain WhyJul 31 2023, 1:19 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM206d67e9da1c: [lib] add reply/replies back to sidebar inline engagement.

Revision Contents
Changeset List

PathSize
lib/
hooks/
2 lines

Diff 29351

View Options

lib/hooks/inline-engagement-text.react.js

// @flow // @flow
import reduceConnectionInfo from './connection-reducer.js';
import { reduceDeviceToken } from './device-token-reducer.js'; import { reduceDeviceToken } from './device-token-reducer.js';
import { unsupervisedBackgroundActionType } from './lifecycle-state-reducer.js'; import { unsupervisedBackgroundActionType } from './lifecycle-state-reducer.js';
import { updateActivityActionTypes } from '../actions/activity-actions.js'; import { updateActivityActionTypes } from '../actions/activity-actions.js';
import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js'; import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js';
import { import {
addKeyserverActionType, addKeyserverActionType,
removeKeyserverActionType, removeKeyserverActionType,
} from '../actions/keyserver-actions.js'; } from '../actions/keyserver-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js'; import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import { import {
logInActionTypes,
resetUserStateActionType,
logOutActionTypes, logOutActionTypes,
deleteAccountActionTypes, deleteAccountActionTypes,
registerActionTypes, registerActionTypes,
logInActionTypes,
resetUserStateActionType,
} from '../actions/user-actions.js'; } from '../actions/user-actions.js';
import { queueActivityUpdatesActionType } from '../types/activity-types.js'; import { queueActivityUpdatesActionType } from '../types/activity-types.js';
import type { KeyserverStore } from '../types/keyserver-types'; import type { KeyserverStore } from '../types/keyserver-types';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
updateConnectionStatusActionType, updateConnectionStatusActionType,
setLateResponseActionType,
updateDisconnectedBarActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { processUpdatesActionType } from '../types/update-types.js'; import { processUpdatesActionType } from '../types/update-types.js';
import { setNewSessionActionType } from '../utils/action-utils.js'; import { setNewSessionActionType } from '../utils/action-utils.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { setURLPrefix } from '../utils/url-utils.js'; import { setURLPrefix } from '../utils/url-utils.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
export default function reduceKeyserverStore( export default function reduceKeyserverStore(
state: KeyserverStore, state: KeyserverStore,
action: BaseAction, action: BaseAction,
): KeyserverStore { ): KeyserverStore {
if ( if (action.type === addKeyserverActionType) {
action.type === logOutActionTypes.success ||
action.type === deleteAccountActionTypes.success
) {
state = {
keyserverInfos: {
[ashoatKeyserverID]: {
...state.keyserverInfos[ashoatKeyserverID],
},
},
};
} else if (action.type === addKeyserverActionType) {
return { return {
...state, ...state,
keyserverInfos: { keyserverInfos: {
...state.keyserverInfos, ...state.keyserverInfos,
[action.payload.keyserverAdminUserID]: { [action.payload.keyserverAdminUserID]: {
...action.payload.newKeyserverInfo, ...action.payload.newKeyserverInfo,
}, },
}, },
Show All 31 Lines if (action.payload.sessionChange.cookie !== undefined) {
...state.keyserverInfos, ...state.keyserverInfos,
[keyserverID]: { [keyserverID]: {
...state.keyserverInfos[keyserverID], ...state.keyserverInfos[keyserverID],
cookie: action.payload.sessionChange.cookie, cookie: action.payload.sessionChange.cookie,
}, },
}, },
}; };
} }
if (action.payload.sessionChange.cookieInvalidated) {
state = {
...state,
keyserverInfos: {
...state.keyserverInfos,
[keyserverID]: {
...state.keyserverInfos[keyserverID],
connection: {
...state.keyserverInfos[keyserverID].connection,
queuedActivityUpdates: [],
},
},
},
};
}
} else if ( } else if (
action.type === logInActionTypes.success || action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success action.type === siweAuthActionTypes.success
) { ) {
const { updatesCurrentAsOf } = action.payload; const { updatesCurrentAsOf } = action.payload;
for (const keyserverID in updatesCurrentAsOf) { for (const keyserverID in updatesCurrentAsOf) {
state = { state = {
...state, ...state,
▲ Show 20 Lines • Show All 163 Lines • ▼ Show 20 Lines for (const keyserverID in activityUpdates) {
connection: { ...oldConnection, queuedActivityUpdates }, connection: { ...oldConnection, queuedActivityUpdates },
}, },
}; };
} }
state = { state = {
...state, ...state,
keyserverInfos, keyserverInfos,
}; };
} } else if (
action.type === logOutActionTypes.success ||
action.type === deleteAccountActionTypes.success
) {
// We want to remove all keyservers but Ashoat's keyserver
const oldConnection = state.keyserverInfos[ashoatKeyserverID].connection;
const connection = reduceConnectionInfo( const keyserverInfos = {
state.keyserverInfos[ashoatKeyserverID].connection, [ashoatKeyserverID]: {
action, ...state.keyserverInfos[ashoatKeyserverID],
connection: { ...oldConnection, queuedActivityUpdates: [] },
},
};
state = {
...state,
keyserverInfos,
};
} else if (action.type === setLateResponseActionType) {
const { messageID, isLate, keyserverID } = action.payload;
const lateResponsesSet = new Set<number>(
state.keyserverInfos[keyserverID].connection.lateResponses,
); );
if (isLate) {
lateResponsesSet.add(messageID);
} else {
lateResponsesSet.delete(messageID);
}
state = {
...state,
keyserverInfos: {
...state.keyserverInfos,
[keyserverID]: {
...state.keyserverInfos[keyserverID],
connection: {
...state.keyserverInfos[keyserverID].connection,
lateResponses: [...lateResponsesSet],
},
},
},
};
} else if (action.type === updateDisconnectedBarActionType) {
const { keyserverID } = action.payload;
state = {
...state,
keyserverInfos: {
...state.keyserverInfos,
[keyserverID]: {
...state.keyserverInfos[keyserverID],
connection: {
...state.keyserverInfos[keyserverID].connection,
showDisconnectedBar: action.payload.visible,
},
},
},
};
}
const deviceToken = reduceDeviceToken( const deviceToken = reduceDeviceToken(
state.keyserverInfos[ashoatKeyserverID].deviceToken, state.keyserverInfos[ashoatKeyserverID].deviceToken,
action, action,
); );
if ( if (deviceToken !== state.keyserverInfos[ashoatKeyserverID].deviceToken) {
connection !== state.keyserverInfos[ashoatKeyserverID].connection ||
deviceToken !== state.keyserverInfos[ashoatKeyserverID].deviceToken
) {
state = { state = {
...state, ...state,
keyserverInfos: { keyserverInfos: {
...state.keyserverInfos, ...state.keyserverInfos,
[ashoatKeyserverID]: { [ashoatKeyserverID]: {
...state.keyserverInfos[ashoatKeyserverID], ...state.keyserverInfos[ashoatKeyserverID],
connection,
deviceToken, deviceToken,
}, },
}, },
}; };
} }
return state; return state;
} }