Page MenuHomePhabricator
Differential D8496

[native] clean up InlineEngagement component
ClosedPublic
Actions

Authored by ginsu on Jul 13 2023, 9:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 3:59 AM
Unknown Object (File)
Fri, Nov 1, 1:47 PM
Unknown Object (File)
Mon, Oct 28, 7:43 AM
Unknown Object (File)
Oct 1 2024, 9:39 PM
Unknown Object (File)
Oct 1 2024, 9:10 PM
Unknown Object (File)
Sep 28 2024, 9:32 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
View All 76 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM2d893db09936: [native] clean up InlineEngagement component
Summary

Small cleanup diff to better organize and make the InlineEngagement component easier to read/go through. The two changes to note are

  1. Renamed threadInfo to sidebarInfo: I thought that this was a more accurate name since this was holding the sidebar thread info
  2. Reorganized/moved the styles unboundStyles so that the order of the styles went from usage in parent elements/containers to the children elements. Before this the styles were in some random order that didn't make any sense to me

Depends on D8317

Test Plan

Confirmed that InlineEngagment still looked and behaved the same.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 13 2023, 9:53 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 13 2023, 9:53 AM
ginsu edited the summary of this revision. (Show Details)Jul 13 2023, 10:03 AM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8317: [lib] add reply/replies back to sidebar inline engagement.
Harbormaster completed remote builds in B20922: Diff 28676.Jul 13 2023, 10:10 AM
ginsu requested review of this revision.Jul 13 2023, 10:10 AM
ginsu added a child revision: D8497: [native] split the inline engagement pill into two.Jul 13 2023, 2:49 PM
kamil accepted this revision.Jul 19 2023, 5:00 AM
kamil added inline comments.
native/chat/inline-engagement.react.js
34 ↗(On Diff #28676)

after this change feels a bit not natural that this is not a SidebarInfo type, but overall your reasoning is convincing

This revision is now accepted and ready to land.Jul 19 2023, 5:00 AM
ginsu added inline comments.Jul 26 2023, 1:04 PM
native/chat/inline-engagement.react.js
34 ↗(On Diff #28676)

That is a fair point. I think an even better name for this would be sidebarThreadInfo. Will update this diff to reflect this

ginsu updated this revision to Diff 29073.Jul 26 2023, 1:11 PM

address comments

Harbormaster completed remote builds in B21229: Diff 29073.Jul 26 2023, 1:30 PM
ginsu mentioned this in D8677: [web] clean up InlineEngagement component.Jul 31 2023, 7:18 AM
ginsu updated this revision to Diff 29300.Jul 31 2023, 11:31 AM

rebase before landing

Harbormaster completed remote builds in B21388: Diff 29300.Jul 31 2023, 12:36 PM
Closed by commit rCOMM2d893db09936: [native] clean up InlineEngagement component (authored by ginsu). · Explain WhyJul 31 2023, 1:19 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2d893db09936: [native] clean up InlineEngagement component.
ginsu mentioned this in rCOMM9c1905dc7549: [web] clean up InlineEngagement component.Jul 31 2023, 1:28 PM

Revision Contents
Changeset List

Diff 29352

View Options

native/chat/composed-message.react.js

Loading...
View Options

native/chat/inline-engagement.react.js

Loading...
View Options

native/chat/robotext-message.react.js

Loading...