Page MenuHomePhabricator

[native] update heightMeasurerKey function to consider inline engagement for text messages
ClosedPublic

Authored by ginsu on Jul 25 2023, 2:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:57 PM
Unknown Object (File)
Sat, Nov 23, 4:24 PM
Unknown Object (File)
Sat, Nov 23, 4:24 PM
Unknown Object (File)
Mon, Nov 11, 3:45 PM
Unknown Object (File)
Fri, Nov 1, 2:22 PM
Unknown Object (File)
Fri, Nov 1, 2:22 PM
Unknown Object (File)
Fri, Nov 1, 2:22 PM
Unknown Object (File)
Fri, Nov 1, 2:21 PM
Subscribers

Details

Summary

This next diff updates the heightMeasurerKey function so that we remeasure a text message whenever there is a change with the inline engagement for that text message. In this diff we want to also consider changes to sidebar text and the reactions, and the edited label since these can all potentially affect the height of the inline engagement node

Depends on D8630

Test Plan

I tested modifying the height of the inline engagement for text messages, and when I did this I no longer got incorrect height measurement logs from the console. Also confirmed that there were no incorrect height measurements for android

When modifying the height I tried various things:

  • introducing/removing reactions (demo below)
  • introducing a sidebar to the inline engagement (pushing some of the reactions to a new row)
  • introducing the edited label to the inline engagement (pushing some reactions to a new row)

With all of these tests, I did not get any logs about incorrect height measurements.

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Jul 25 2023, 2:43 PM
This revision is now accepted and ready to land.Jul 26 2023, 3:24 AM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Jul 31 2023, 1:19 PM
This revision was automatically updated to reflect the committed changes.